Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if unzip is present on the current system. #1435

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Check if unzip is present on the current system. #1435

merged 1 commit into from
Aug 4, 2021

Conversation

okin
Copy link
Contributor

@okin okin commented Aug 4, 2021

What this PR does / why we need it:

Gives the user an error message if the required "unzip" command is missing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1337

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

* Install script: Warn and exit if required unzip program is missing

@okin
Check if unzip is present on the current system.
1ac3dbf 
Closes kubermatic#1337

Signed-off-by: Niko Wenselowski <der@nik0.de>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2021
@kubermatic-bot
Copy link
Contributor

Hi @okin. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2021
kron4eg
kron4eg approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ee30cbc6f280a023d7d1ecd4d770d077122dd416

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, okin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@kubermatic-bot kubermatic-bot merged commit 94deef3 into kubermatic:master Aug 4, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Aug 4, 2021
@okin okin deleted the 1337-check-for-unzip branch August 4, 2021 20:58
hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 26, 2021
@hwuethrich
Merge remote-tracking branch 'upstream/master'
1c79dce 
* upstream/master:
  Increase the minimum Kubernetes version to v1.19 (kubermatic#1466)
  Automatically deploy CSI plugin and driver for supported providers, and add support for OpenStack Cinder CSI (kubermatic#1465)
  Add support for versioned images (kubermatic#1463)
  Add changelog for v1.3.0-alpha.1 release (kubermatic#1460)
  Use kubeadm/v1beta3 API for Kubernetes 1.22+ clusters (kubermatic#1457)
  Enable PodSecurity admission controller for 1.22 clusters (kubermatic#1456)
  Add Kubernetes 1.22 tests and remove 1.18 tests (kubermatic#1447)
  Extend restart API server script to handle failing crictl logs (kubermatic#1448)
  Remove upx from the kubeone-e2e image (kubermatic#1443)
  terraform/vsphere: Inherit firmware settings from the template VM (kubermatic#1445)
  Update machine-controller to v1.35.1 (kubermatic#1440)
  Redirect push-e2e-image job failures to the appropriate channel (kubermatic#1442)
  Update images (kubermatic#1441)
  Azure CCM (kubermatic#1438)
  Upgrade machine-controller to v1.35.0 (kubermatic#1437)
  Check if unzip is present on the current system. (kubermatic#1435)
cedi pushed a commit to cedi/kubeone that referenced this pull request Oct 8, 2021
@okin
Check if unzip is present on the current system. (kubermatic#1435)
565bb2e 
Closes kubermatic#1337

Signed-off-by: Niko Wenselowski <der@nik0.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.

Install-script fails because of missing unzip
3 participants
@okin @kubermatic-bot @kron4eg