terraform/vsphere: Inherit firmware settings from the template VM #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
kron4eg
approved these changes
Aug 13, 2021
|
LGTM label has been added. Git tree hash: bd43d071888b5252e2a0609ccfd8f116e08889b9
|
hwuethrich
added a commit
to hwuethrich/kubeone
that referenced
this pull request
Aug 26, 2021
* upstream/master: Increase the minimum Kubernetes version to v1.19 (kubermatic#1466) Automatically deploy CSI plugin and driver for supported providers, and add support for OpenStack Cinder CSI (kubermatic#1465) Add support for versioned images (kubermatic#1463) Add changelog for v1.3.0-alpha.1 release (kubermatic#1460) Use kubeadm/v1beta3 API for Kubernetes 1.22+ clusters (kubermatic#1457) Enable PodSecurity admission controller for 1.22 clusters (kubermatic#1456) Add Kubernetes 1.22 tests and remove 1.18 tests (kubermatic#1447) Extend restart API server script to handle failing crictl logs (kubermatic#1448) Remove upx from the kubeone-e2e image (kubermatic#1443) terraform/vsphere: Inherit firmware settings from the template VM (kubermatic#1445) Update machine-controller to v1.35.1 (kubermatic#1440) Redirect push-e2e-image job failures to the appropriate channel (kubermatic#1442) Update images (kubermatic#1441) Azure CCM (kubermatic#1438) Upgrade machine-controller to v1.35.0 (kubermatic#1437) Check if unzip is present on the current system. (kubermatic#1435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the Terraform configs for vSphere to inherit the firmware settings from the template VM. By default, BIOS is used as firmware:
This can cause a problem if the template was created with EFI. In that case, the created machine would use BIOS and it could be unbootable because the template machine was configured as an EFI machine.
Does this PR introduce a user-facing change?:
/assign @kron4eg