Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit selinux config file only if file exists #1532

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Sep 17, 2021

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1446

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Edit selinux config file only if file exists

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 17, 2021
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2021
@kron4eg kron4eg marked this pull request as ready for review September 17, 2021 12:18
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd632f907eab71db3926d36581df76da5eaab1a3

@kron4eg
Copy link
Member Author

kron4eg commented Sep 17, 2021

/retest

@kubermatic-bot kubermatic-bot merged commit edcb61d into kubermatic:master Sep 17, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Sep 17, 2021
@kron4eg kron4eg deleted the selinux-config-file branch September 17, 2021 15:11
xmudrii pushed a commit that referenced this pull request Oct 27, 2021
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@xmudrii
Copy link
Member

xmudrii commented Oct 27, 2021

Cherry-picked to release/v1.3 branch with #1592.

kubermatic-bot pushed a commit that referenced this pull request Oct 27, 2021
* edit selinux config file only if file exists (#1532)

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* openstack-terraform: open nodeports SG (#1530)

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* gce-terraform: Open GCE nodeports (#1529)

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* azure-terraform: allow nodeports (#1528)

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* Bump Hetzner Cloud CCM to latest version (#1583)

Signed-off-by: Mattias Gees <mattias.gees@gmail.com>

Co-authored-by: Artiom Diomin <artiom@loodse.com>
Co-authored-by: Mattias Gees <mattias.gees@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing selinux files on CentOS causes failure of kubeone apply
3 participants