Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.3] Use semver constraints on Kubernetes version for upper and lower bounds #1817

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

embik
Copy link
Member

@embik embik commented Feb 8, 2022

What this PR does / why we need it:
This is a cherry-pick of #1808 to release/v1.3, adjusted to the supported Kubernetes versions as per https://docs.kubermatic.com/kubeone/v1.3/architecture/compatibility/#supported-kubernetes-versions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Validate Kubernetes version against supported versions constraints

…ds (kubermatic#1808)

* Use semver constraints on Kubernetes version for upper and lower bounds

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Fix linting issues

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Improve constraint usage and correctly append errors

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Use mustParseConstraint

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Fix test case

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Appease linter

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 8, 2022
@embik embik requested a review from xmudrii February 8, 2022 10:24
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2022
@embik embik changed the title [release/v1.3] Use semver constraints on Kubernetes version for upper and lower bounds (#1808) [release/v1.3] Use semver constraints on Kubernetes version for upper and lower bounds Feb 8, 2022
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6dbee7d54028c4abd7b1ce046902ee59d954cdec

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@kubermatic-bot kubermatic-bot merged commit 13e9f34 into kubermatic:release/v1.3 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants