Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terraform consistent variables for machine deployment replicas #2115

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Fix terraform consistent variables for machine deployment replicas #2115

merged 2 commits into from
Jun 24, 2022

Conversation

adeniyistephen
Copy link
Contributor

@adeniyistephen adeniyistephen commented Jun 23, 2022 •
edited by xmudrii
Loading

What type of PR is this?
Fixing terraform variables for consistency among cloud providers
/kind feature

What this PR does / why we need it:
To enable consistent variables among cloud providers for the machine deployment replicas.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/kubermatic/ps-team-flotilla/issues/99 ticket

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

ACTION REQUIRED: `workers_replicas` variable has been renamed to `initial_machinedeployment_replicas` in example Terraform configs for Hetzner

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2022
ahmedwaleedmalik
ahmedwaleedmalik suggested changes Jun 23, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please document this new variable initial_machinedeployment_replicas in the respective README.md files for the cloud providers as well? For example, https://github.com/kubermatic/kubeone/blob/master/examples/terraform/aws/README.md#L69

You are also missing a release note and kind(/kind feature) in your PR description.

@kron4eg kron4eg added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 24, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 24, 2022
@kron4eg
Copy link
Member

kron4eg commented Jun 24, 2022 •
edited
Loading

@adeniyistephen please add a release note (in the PR description) about breaking change in hetzner terraform config.
As of updating READMEs like @ahmedwaleedmalik said please leave that along for now. I'll update them later by myself and add some automation to update in the future.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2022
@adeniyistephen
Copy link
Contributor Author

Done.

@kron4eg kron4eg removed the kind/documentation Categorizes issue or PR as related to documentation. label Jun 24, 2022
@kubermatic-bot kubermatic-bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 24, 2022
@kron4eg
Copy link
Member

kron4eg commented Jun 24, 2022

/kind feature

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 24, 2022
@kron4eg
Copy link
Member

kron4eg commented Jun 24, 2022

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dfbeaf22a3eacac4fd3529b90b7811b1f06002d6

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@kubermatic-bot kubermatic-bot merged commit 632c854 into kubermatic:master Jun 24, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.5 milestone Jun 24, 2022
@kron4eg
Copy link
Member

kron4eg commented Jun 24, 2022

@ahmedwaleedmalik since you've required it, here it is: #2117

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 24, 2022
@xmudrii
Copy link
Member

xmudrii commented Jun 24, 2022

I updated the release note to replace BREAKING with ACTION REQUIRED so the changelog generator picks it up properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@adeniyistephen @kron4eg @kubermatic-bot @xmudrii @ahmedwaleedmalik