-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Kubernetes 1.30 support #3234
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
/lgtm |
LGTM label has been added. Git tree hash: c8118959d913500ee56a4cf348d5054474e4651b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small question from my side
/cherrypick release/v1.8 |
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
@xmudrii: #3234 failed to apply on top of branch "release/v1.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release/v1.8 |
@xmudrii: new pull request created: #3242 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR introduces several improvements and bug fixes to our Kubernetes 1.30 support:
cri-tools
version for Kubernetes 1.30 on Flatcar--certificate-renew=true
and--yes
flags fromkubeadm upgrade apply
command as it's not possible to combine the--config
flag with other flags as ofkubeadm
1.30--certificate-renew=true
flag is a no-op change because the flag istrue
by default--yes
flag means that we runkubeadm
in the interactive mode and thatkubeadm
will ask user to typeyes
to confirm upgrading the cluster. As KubeOne doesn't support interactive inputs, we mitigate this by pipingyes
to thekubeadm upgrade apply
commandt3.nano
instead oft3a.nano
for the bastion instancet3a.nano
any longer, the instance is stuck in initializing and it's not possible to SSH to itAdditionally, this PR does some bookkeeping work:
cri-tools
version for a new Kubernetes version on FlatcarUpdate images
template with the latest changesWhich issue(s) this PR fixes:
xref #3205 #3206
What type of PR is this?
/kind bug
/kind cleanup
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
/assign @kron4eg @xrstf