-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Helm Release Timeout Issue #3240
Conversation
fix helm release timeout issue
/approve |
LGTM label has been added. Git tree hash: 886666d72b62ced17ecf056642015f4b6549fc8a
|
/hold |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: ca27fe7e776e5e0347350b4d626b055582d061e9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
/retest |
What this PR does / why we need it:
Fix
HelmRelease.WaitTimeout
parsing issue (it does not support human-readable format). This PR Usemetav1.Duration
Instead oftime.Duration
typeWhich issue(s) this PR fixes:
Fixes #3239
What type of PR is this?
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: