Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helm Release Timeout Issue #3240

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

mohamed-rafraf
Copy link
Member

@mohamed-rafraf mohamed-rafraf commented Jun 18, 2024

What this PR does / why we need it:

Fix HelmRelease.WaitTimeout parsing issue (it does not support human-readable format). This PR Use metav1.Duration Instead of time.Duration type

Which issue(s) this PR fixes:

Fixes #3239

What type of PR is this?

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Change the API type of the `.helmReleases[*].timeout` field to `k8s.io/apimachinery/pkg/apis/meta/v1.Duration` to match other Duration fields in the API and to allow specifying human-readable duration (e.g. `2m0s`)

Documentation:

NONE

fix helm release timeout issue
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2024
@mohamed-rafraf
Copy link
Member Author

/assign
/cc @xmudrii @kron4eg

@kron4eg
Copy link
Member

kron4eg commented Jun 18, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 886666d72b62ced17ecf056642015f4b6549fc8a

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2024

/hold
for #3234 to get merged first

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2024

/hold cancel
/kind bug api-change

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 18, 2024
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca27fe7e776e5e0347350b4d626b055582d061e9

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2024

/release-note-edit

Change the API type of the `.helmReleases[*].timeout` field to `k8s.io/apimachinery/pkg/apis/meta/v1.Duration` to match other Duration fields in the API and to allow specifying human-readable duration (e.g. `2m0s`)

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 18, 2024
@mohamed-rafraf
Copy link
Member Author

/retest

@kubermatic-bot kubermatic-bot merged commit bce2ed9 into kubermatic:main Jun 18, 2024
15 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Releases timeout is not working with human-readable format
4 participants