fix: WebSocketOutputStream wait to write until WebSocket queue is released #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eased Signed-off-by: Daniel Arteaga Barba <darteaga@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Signed-off-by: Daniel Arteaga Barba <darteaga@vmware.com>
| while (WebSocketStreamHandler.this.socket.queueSize() + byteString.size() > MAX_QUEUE_SIZE | ||
| && attempts < MAX_QUEUE_SIZE_MAX_ATTEMPTS) { | ||
| try { | ||
| Thread.sleep(MAX_QUEUE_SIZE_WAIT_MILLISECONDS); |
Contributor
There was a problem hiding this comment.
Rather than just straight sleeping, what do you think about using wait(MAX_TIME)/notify here. It would reduce latency and also be more efficient.
Contributor
Author
There was a problem hiding this comment.
Great suggestion! it is actually way long better
Using wait (~3min)
# exec 1
2022-09-27T14:12:16.502+0200 [ main][DEBUG] Copying /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/12395450492776725845 to default:tests-c58fcf48c-n5w8f:/tmp
2022-09-27T14:15:44.043+0200 [ main][DEBUG] Copied /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/12395450492776725845
# exec 2
2022-09-27T14:27:31.007+0200 [ main][DEBUG] Copying /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/8625417876961582076 to default:tests-c58fcf48c-n5w8f:/tmp
2022-09-27T14:30:51.087+0200 [ main][DEBUG] Copied /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/8625417876961582076
Using Thread.sleep (~4min)
# exec 1
2022-09-27T14:38:52.833+0200 [ main][DEBUG] Copying /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/422416366883411235 to default:tests-c58fcf48c-n5w8f:/tmp
2022-09-27T14:42:23.119+0200 [ main][DEBUG] Copied /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/422416366883411235
# exec 2
2022-09-27T15:24:35.732+0200 [ main][DEBUG] Copying /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/2455455714318474992 to default:tests-c58fcf48c-n5w8f:/tmp
2022-09-27T15:28:35.794+0200 [ main][DEBUG] Copied /var/folders/v_/9khlk6_94hg0q1prl51fxbkh0000gp/T/tests-workplace-2455455714318474992
util/src/main/java/io/kubernetes/client/util/WebSocketStreamHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Arteaga Barba <darteaga@vmware.com>
k8s-ci-robot
added
size/M
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, dani8art The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
dani8art
pushed a commit
to dani8art/kubernetes-client-java
that referenced
this pull request
Oct 21, 2022
…dding-data-to-queue fix: WebSocketOutputStream wait to write until WebSocket queue is released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Arteaga Barba darteaga@vmware.com
This PR is a proposal for the following issue:#2309 based in this comment: #2309 (comment)