Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s to v.0.22.3 #241

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Bump k8s to v.0.22.3 #241

merged 1 commit into from
Nov 16, 2021

Conversation

pierreprinetti
Copy link
Contributor

@pierreprinetti pierreprinetti commented Nov 8, 2021 •
edited
Loading

Fully address CVE-2021-3121 in the process.

Fixes #188

Bump Kubernetes to v0.22.3. Completely address CVE-2021-3121

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @pierreprinetti!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @pierreprinetti. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 8, 2021
@pierreprinetti
Copy link
Contributor Author

/assign @jsafrane

@coveralls
Copy link

coveralls commented Nov 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1462486454

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.466%
Totals Coverage Status
Change from base Build 1462424806: 0.0%
Covered Lines: 532
Relevant Lines: 678
💛 - Coveralls

@pierreprinetti
Copy link
Contributor Author

recheck

@pierreprinetti
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@pierreprinetti: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

jsafrane commented Nov 9, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2021
@jsafrane
Copy link
Contributor

jsafrane commented Nov 9, 2021

code lgtm, but I don't like Windows tests failing

Error: vendor\k8s.io\client-go\plugin\pkg\client\auth\exec\metrics.go:21:2: cannot find package "." in:
	D:\a\csi-driver-nfs\csi-driver-nfs\vendor\io\fs

@pierreprinetti
Copy link
Contributor Author

/retest

@pierreprinetti pierreprinetti force-pushed the CVE-2021-3121 branch 4 times, most recently from 5bf0870 to 59cb47d Compare November 15, 2021 12:34
@pierreprinetti
Copy link
Contributor Author

@jsafrane

Windows tests failing

Depends on #244

@pierreprinetti
Bump k8s to v.0.22.3
6abb111 
Fully address CVE-2021-3121 in the process.
@pierreprinetti
Copy link
Contributor Author

Everything's green now :)

PTAL @jsafrane

andyzhangx
andyzhangx approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@andyzhangx andyzhangx merged commit 5642e44 into kubernetes-csi:master Nov 16, 2021
@pierreprinetti pierreprinetti deleted the CVE-2021-3121 branch November 16, 2021 10:29
@pierreprinetti pierreprinetti mentioned this pull request Jun 12, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@j-griffith j-griffith Awaiting requested review from j-griffith

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@jsafrane jsafrane

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2021-3121 is present in dependencies
5 participants
@pierreprinetti @k8s-ci-robot @coveralls @jsafrane @andyzhangx