Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows go version #244

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Windows go version #244

merged 2 commits into from
Nov 15, 2021

Conversation

pierreprinetti
Copy link
Contributor

@pierreprinetti pierreprinetti commented Nov 15, 2021 •
edited
Loading

/kind failing-test

What this PR does / why we need it:
Prior to this patch, the Go version for the Windows tests in Github
resolved to 1.15.15.

With this patch, the Go version for the Windows tests is fixed to
actually resolve to the latest version (^1.16), consistent to the other
platforms.

This patch also bumps actions/setup-go to the latest version,
consistent with the other platforms.

Lastly, in order to rapidly debug test issues, issue go version prior to
running any test.

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @pierreprinetti. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2021
@pierreprinetti pierreprinetti mentioned this pull request Nov 15, 2021
Merged
@pierreprinetti
Copy link
Contributor Author

/assign @jsafrane

@pierreprinetti
Copy link
Contributor Author

pierreprinetti commented Nov 15, 2021 •
edited
Loading

go version go1.15.15 windows/amd64

Still perfectible

https://github.com/kubernetes-csi/csi-driver-nfs/runs/4211645999?check_suite_focus=true

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2021
@coveralls
Copy link

coveralls commented Nov 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1462251639

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.466%
Totals Coverage Status
Change from base Build 1462081095: 0.0%
Covered Lines: 532
Relevant Lines: 678
💛 - Coveralls

@pierreprinetti
actions: Fix Windows Go version
0623e9e 
Prior to this patch, the Go version for the Windows tests in Github
resolved to `1.15.15`[1].

With this patch, the Go version for the Windows tests is fixed to
actually resolve to the latest version (^1.16), consistent to the other
platforms.

This patch also bumps `actions/setup-go`[2] to the latest version,
consistent with the other platforms.

[1]: https://github.com/kubernetes-csi/csi-driver-nfs/runs/4211323920?check_suite_focus=true
[2]: https://github.com/actions/setup-go
@pierreprinetti
actions: Print go version
339d4d2 
In order to rapidly debug test issues, issue `go version` prior to
running any test.
@pierreprinetti
Copy link
Contributor Author

This is good to go! All platforms now consistently run 1.17.3.

andyzhangx
andyzhangx approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit da422f9 into kubernetes-csi:master Nov 15, 2021
@pierreprinetti pierreprinetti deleted the windows_go_version branch November 15, 2021 13:58
@pierreprinetti pierreprinetti mentioned this pull request Jun 12, 2023
Closed
9 tasks
andyzhangx added a commit to andyzhangx/csi-driver-nfs that referenced this pull request Dec 16, 2023
@andyzhangx
Squashed 'release-tools/' changes from f8c8cc4..b54c1ba
94797cd 
b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21
5436c81 Change go version to 1.21.5
267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage
b42e5a2 nominate self (carlory) as kubernetes-csi reviewer
a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar
011033d Use set -x instead of die
5deaf66 Add wrapper script for sidecar release

git-subtree-dir: release-tools
git-subtree-split: b54c1ba
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#244 from carlory/sig-storage
267b40e 
nominate self (carlory) as kubernetes-csi reviewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@jsafrane jsafrane

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pierreprinetti @k8s-ci-robot @andyzhangx @coveralls @jsafrane