uk-localization build fix + what is kubernetes? #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit intended to fix issue with building uk localization at all.
|
Схоже це частково дублікує #1 |
* uk-localization: Update horizontal-pod-autoscale.md Update replicationcontroller.md Update persistent-volumes.md Update secret.md Update _index.html Update content/uk/docs/concepts/workloads/controllers/deployment.md Update content/uk/docs/concepts/storage/persistent-volumes.md Update content/uk/docs/concepts/storage/persistent-volumes.md Update content/uk/_index.html Update content/uk/_index.html Update content/uk/_index.html Update content/uk/docs/concepts/services-networking/endpoint-slices.md
+ переклад статті "що таке кубернетес" + незначні зміни до індексного файлу (без них проект не буде створено)
нотатки
чекаю на ваші коментарі панове та панянки |
butuzov
changed the title
Co-Authored-By: Anastasiya Kulyk <56824659+anastyakulyk@users.noreply.github.com>
Co-Authored-By: Anastasiya Kulyk <56824659+anastyakulyk@users.noreply.github.com>
Co-Authored-By: Anastasiya Kulyk <56824659+anastyakulyk@users.noreply.github.com>
Co-Authored-By: Anastasiya Kulyk <56824659+anastyakulyk@users.noreply.github.com>
…v/kubernetes-website into uk-localization-index-fix * 'uk-localization-index-fix' of https://github.com/butuzov/kubernetes-website: Update content/uk/docs/concepts/overview/what-is-kubernetes.md Update content/uk/docs/concepts/overview/what-is-kubernetes.md Update content/uk/docs/concepts/overview/what-is-kubernetes.md Update content/uk/docs/concepts/overview/what-is-kubernetes.md # Conflicts: # content/uk/docs/concepts/overview/what-is-kubernetes.md
|
дякую за гарне ревю, я від ніього не скоро відійду! =) З/И/ |
MaxymVlasov
requested changes
Feb 11, 2020
There was a problem hiding this comment.
Я пас'ятаю що PR був не по локалізації, однак)
Може @anastyakulyk виправить. До того ж, я там по гломапію понакидував.
Насть, збери, будь ласка, це добро кудись і постав по емоджі під коментарями про гломарій - щоб розуміти що тред можна без резолвити
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
поки хай буде. Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
|
Я зараз пройдусь по зауваженнях, що можу буду виправляти та пушити окремим коммітом. |
* uk-localization: Update content/uk/docs/tasks/run-application/horizontal-pod-autoscale.md Fix crosslinks localize heading and subheading URL Localize heading and subheading URLs Localize heading and subheading URLs
MaxymVlasov
reviewed
Feb 13, 2020
* uk-localization: Restore originl and move localization to right path
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
…v/kubernetes-website into uk-localization-index-fix * 'uk-localization-index-fix' of https://github.com/butuzov/kubernetes-website: Update content/uk/docs/concepts/overview/what-is-kubernetes.md Update content/uk/docs/concepts/overview/what-is-kubernetes.md Update content/uk/docs/concepts/overview/what-is-kubernetes.md
Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
|
Чи є у когось ще зауваження чи можемо переходити до зливання wtfk8s ? |
|
Як на мене, все ок |
|
закрито на користь #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Нормалізуємо білд:
В данному PR буде мінімально допустимий набір файлів для створення білда сайту. Метою PR не є локалізація або провадження локалізованих матеріалів, але створення працездатного білда.
WIP.