Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

make the fsid device setting configurable #1214

Merged

Conversation

thirdeyenick
Copy link
Contributor

This makes the fsid_device setting configurable. To not affect already deployed nfs provisioners I did not change the default to false. This should solve issue #1212.

@k8s-ci-robot
Copy link
Contributor

Welcome @thirdeyenick!

It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2019
@thirdeyenick
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 28, 2019
@wongma7
Copy link
Contributor

wongma7 commented Aug 29, 2019

Thx for prs. I’m looking into why e2e is not building/running, it worked a few days ago.

@wongma7
Copy link
Contributor

wongma7 commented Sep 5, 2019

/lgtm
/approve
thanks again.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3ee1c0c into kubernetes-retired:master Sep 5, 2019
@cedricve
Copy link

@thirdeyenick cool, having the same issue. Would you have an example yaml file, which shows how to use it?

@cedricve
Copy link

@thirdeyenick sorry to disturb, but still looking around a fix, as this hasn't been merged into the helm repo (helm/charts#18965). I was wondering how you fixed it. Any help is more than welcome! Super thanks Nick.

@cedricve
Copy link

cedricve commented Jan 26, 2020

@wongma7 any chance a new release would be made for this? Thanks! It looks that it is not included in v2.2.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants