Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

master: CoreDNS prometheus metric annotations exposed at pod level #1769

Merged

Conversation

kfr2
Copy link
Contributor

@kfr2 kfr2 commented Oct 28, 2019

These annotations would previously never be rendered because they
were added under the kube-dns section (rather than CoreDNS's).
Additionally, the annotations are now added to the Pods themselves
rather than the Deployment.

Fixes #1768

@k8s-ci-robot
Copy link
Contributor

Welcome @kfr2!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 28, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2019
@kfr2 kfr2 force-pushed the coredns-prometheus-metrics branch from 075748f to bc4693c Compare October 28, 2019 13:10
@kfr2
Copy link
Contributor Author

kfr2 commented Oct 28, 2019

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 28, 2019
@kfr2 kfr2 force-pushed the coredns-prometheus-metrics branch from bc4693c to 93586ac Compare October 28, 2019 13:36
@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #1769 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1769   +/-   ##
=======================================
  Coverage   24.76%   24.76%           
=======================================
  Files          98       98           
  Lines        5023     5023           
=======================================
  Hits         1244     1244           
  Misses       3640     3640           
  Partials      139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6fa4...93586ac. Read the comment docs.

These annotations would previously never be rendered because they
were added under the kube-dns section (rather than CoreDNS's).
Additionally, the annotations are now added to the Pods themselves
rather than the Deployment.
@kfr2 kfr2 force-pushed the coredns-prometheus-metrics branch from 93586ac to 2a1c60f Compare October 28, 2019 14:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 28, 2019
@kfr2 kfr2 changed the title CoreDNS prometheus metric annotations exposed at pod level master: CoreDNS prometheus metric annotations exposed at pod level Oct 28, 2019
@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@dominicgunn dominicgunn added this to the v0.15.0 milestone Oct 28, 2019
@dominicgunn dominicgunn merged commit a4e9f10 into kubernetes-retired:master Nov 4, 2019
@kfr2 kfr2 deleted the coredns-prometheus-metrics branch November 4, 2019 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus annotations are never added to CoreDNS pods
4 participants