-
Notifications
You must be signed in to change notification settings - Fork 294
master: CoreDNS prometheus metric annotations exposed at pod level #1769
master: CoreDNS prometheus metric annotations exposed at pod level #1769
Conversation
Welcome @kfr2! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
075748f
to
bc4693c
Compare
I signed it |
bc4693c
to
93586ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
=======================================
Coverage 24.76% 24.76%
=======================================
Files 98 98
Lines 5023 5023
=======================================
Hits 1244 1244
Misses 3640 3640
Partials 139 139 Continue to review full report at Codecov.
|
These annotations would previously never be rendered because they were added under the kube-dns section (rather than CoreDNS's). Additionally, the annotations are now added to the Pods themselves rather than the Deployment.
93586ac
to
2a1c60f
Compare
/lgtm |
These annotations would previously never be rendered because they
were added under the kube-dns section (rather than CoreDNS's).
Additionally, the annotations are now added to the Pods themselves
rather than the Deployment.
Fixes #1768