-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install efs-utils from github #442
Conversation
Hi @kbasv. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-aws-efs-csi-driver-e2e |
/retest |
7c0b7aa
to
3b826bb
Compare
/test pull-aws-efs-csi-driver-e2e |
Flaky e2e Tests.
|
Retry e2e after marking restart tests as disruptive |
/test pull-aws-efs-csi-driver-e2e |
/test pull-aws-efs-csi-driver-e2e |
2 similar comments
/test pull-aws-efs-csi-driver-e2e |
/test pull-aws-efs-csi-driver-e2e |
…l efs-utils from Amazon Linux 2 yum repo
/test pull-aws-efs-csi-driver-e2e |
1 similar comment
/test pull-aws-efs-csi-driver-e2e |
RUN yum install amazon-efs-utils-1.30.1-1.amzn2.noarch -y | ||
# Install efs-utils from github by default. It can be overriden to `yum` with --build-arg when building the Docker image. | ||
# If value of `EFSUTILSSOURCE` build arg is overriden with `yum`, docker will install efs-utils from Amazon Linux 2's yum repo. | ||
ARG EFSUTILSSOURCE=github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, to be consistent with EFS_CLIENT_SOURCE it should be underscore separated :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to be consistent with TARGETOS
and TARGETARCH
. I can make the arg EFS_CLIENT_SOURCE
then echo "Installing efs-utils from Amazon Linux 2 yum repo" && \ | ||
yum -y install amazon-efs-utils-1.30.1-1.amzn2.noarch; \ | ||
else echo "Installing efs-utils from github" && \ | ||
yum -y install git rpm-build make && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should remove these packages afterward. I don't think it matters much in terms of size, but also we are constantly getting reports of CVE from packages in the image that we don't even depend on at runtime.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbasv, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
Bump efs-utils to
1.30.2-1
. Install latest efs-utils from github since it is not available on yum . Additionally, provide an option to install efs-utils from yum repo.What testing is done?
Manual tests on my cluster.