Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TCP_UDP to NLB TargetGroups and Listeners (rebase) #3807

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for TCP_UDP to NLB TargetGroups and Listeners (rebase) #3807

wants to merge 3 commits into from

Commits on Oct 20, 2024

  1. fix the regression of IP mode support for fargate pods (kubernetes-si… 

    …gs#2158)
    @M00nF1sh @lyda
    M00nF1sh authored and lyda committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    e4d2c06 View commit details
    Browse the repository at this point in the history

  2. Add support for TCP_UDP to NLB TargetGroups and Listeners 

    Previously, aws-load-balancer-controller ignored extra overlapping
ServicePorts defined in the Kubernetes Service spec if the external port
numbers were the same even if the protocols were different (e.g. TCP:53,
UDP:53).

This behavior prevented users from exposing services that support TCP
and UDP on the same external load balancer port number.

This patch solves the problem by detecting when a user defines multiple
ServicePorts for the same external load balancer port number but using
TCP and UDP protocols separately. In such situations, a TCP_UDP
TargetGroup and Listener are created and SecurityGroup rules are
updated accordingly. If more than two ServicePorts are defined, only the
first two mergeable ServicePorts are used. Otherwise, the first
ServicePort is used.

Note: rebasing errors would be my fault -- Kevin Lyda

Signed-off-by: Kevin Lyda <lyda@titanhq.com>
    @amorey @lyda
    amorey authored and lyda committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    3065a30 View commit details
    Browse the repository at this point in the history

  3. Attempt to address remaining errors

    @lyda
    lyda committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    12bc6a4 View commit details
    Browse the repository at this point in the history