don’t deliver cert-manager CRDs with cluster-api-operator chart

[jackfrancis]

What this PR does / why we need it:

This PR changes the way that the cluster-api-operator chart relates to the cert-manager chart. Rather than package those downstream CRDs with the chart, we can simply dispatch in the cluster-api-operator chart the cert-manager.installCRDs=true value config.

So, with this PR, a simple helm install --repo https://kubernetes-sigs.github.io/cluster-api-operator capi-operator cluster-api-operator command will no longer include the cert-manager CRDs as part of its resource payload.

To explicitly install the cert-manager chart, including the CRDs that are delivered with the cert-manager chart, as part of the cluster-api-operator helm install, we will do:

• helm install --repo https://kubernetes-sigs.github.io/cluster-api-operator capi-operator cluster-api-operator --set cert-manager.enabled=true

If a user wishes to install the cert-manager chart without the CRDs, this is the command:

• helm install --repo https://kubernetes-sigs.github.io/cluster-api-operator capi-operator cluster-api-operator --set cert-manager.enabled=true --set cert-manager.installCRDs=false

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #281

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name	Link
🔨 Latest commit	c8a9022
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/65ea404e176bc2000886dd81
😎 Deploy Preview	https://deploy-preview-453--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alexander-demicev]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexander-demicev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Danil-Grigorev]

/lgtm
Thanks, makes sense to me.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ab686100ef24cec504ed11cad20f48f6c8b35a3a

[zioproto]

Is this change included in chart version 0.9.2 ? Or it needs to be cherry-picked ?

[zioproto]

/cherrypick release-0.9

[k8s-infra-cherrypick-robot]

@zioproto: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zioproto]

@jackfrancis could we cherry-pick this change to have it available in the helm chart ? thanks

[furkatgofurov7]

Is this change included in chart version 0.9.2 ? Or it needs to be cherry-picked ?

@zioproto hey, v0.9.2 is already released and this change was not backported and so not part of that patch release. I think it is fine to be backported and include it in the coming v0.9.3 patch release

/cherrypick release-0.9

[k8s-infra-cherrypick-robot]

@furkatgofurov7: new pull request created: #489

In response to this:

Is this change included in chart version 0.9.2 ? Or it needs to be cherry-picked ?

@zioproto hey, v0.9.2 is already released and this change was not backported and so not part of that patch release. I think it is fine to be backported and include it in the coming v0.9.3 patch release

/cherrypick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.