Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don’t deliver cert-manager CRDs with cluster-api-operator chart #453

Merged
merged 1 commit into from
Mar 13, 2024
Merged

don’t deliver cert-manager CRDs with cluster-api-operator chart #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ release-manifests: $(KUSTOMIZE) $(RELEASE_DIR) ## Builds the manifests to publis
release-chart: $(HELM) $(KUSTOMIZE) $(RELEASE_DIR) $(CHART_DIR) $(CHART_PACKAGE_DIR) ## Builds the chart to publish with a release
cp -rf $(ROOT)/hack/charts/cluster-api-operator/. $(CHART_DIR)
$(KUSTOMIZE) build ./config/chart > $(CHART_DIR)/templates/operator-components.yaml
$(ROOT)/hack/inject-cert-manager-helm.sh $(CERT_MANAGER_VERSION)
$(ROOT)/hack/inject-cert-manager-chart-version.sh $(CERT_MANAGER_VERSION)
$(HELM) package $(CHART_DIR) --app-version=$(HELM_CHART_TAG) --version=$(HELM_CHART_TAG) --destination=$(CHART_PACKAGE_DIR)

.PHONY: release-staging
Expand Down
1 change: 1 addition & 0 deletions hack/charts/cluster-api-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ cert-manager:
enabled: false
fullnameOverride: "cert-manager"
namespace: "cert-manager"
installCRDs: true
# ---
# Cluster API provider options
core: ""
Expand Down
8 changes: 1 addition & 7 deletions hack/inject-cert-manager-helm.sh → hack/inject-cert-manager-chart-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,9 @@ if [[ ! "$1" =~ ^v([0-9]+)\.([0-9]+)\.([0-9]+)$ ]]; then
fi

VERSION=$1
URL="https://github.com/cert-manager/cert-manager/releases/download/${VERSION}/cert-manager.crds.yaml"
OUTPUT_DIR="${CHART_DIR}/crds"

# Create the output directory if it doesn't exist
mkdir -p "$OUTPUT_DIR"

# Download and save the file
curl -L -o "${OUTPUT_DIR}/cert-manager.crds.yaml" "$URL"
echo "Downloaded cert-manager.crds.yaml for ${VERSION} and saved it in ${OUTPUT_DIR}"
mkdir -p "$CHART_DIR"

# Modify version in Chart.yaml
CHART_FILE="${CHART_DIR}/Chart.yaml"
Expand Down
Loading