Fix typo in AWSManagedMachinePool UpdateConfig #3467

phoban01 · 2022-05-12T09:26:10Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I noticed a small typo in the spelling of "percentage" in the struct tag for ``UpdateConfig.MaxUnavailablePercentage`.

Special notes for your reviewer:

Checklist:

squashed commits
includes documentation
adds unit tests
adds or updates e2e tests

linux-foundation-easycla · 2022-05-12T09:26:12Z

The committers listed above are authorized under a signed CLA.

✅ login: phoban01 / name: Piaras Hoban (9a1971f62b5a2c84f74a9ac60dcf493c895a34b0)

k8s-ci-robot · 2022-05-12T09:26:17Z

Welcome @phoban01!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-12T09:26:18Z

@phoban01: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2022-05-12T09:26:18Z

Hi @phoban01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pydctw · 2022-05-12T16:55:13Z

/ok-to-test

pydctw · 2022-05-12T17:10:24Z

@richardcase, is changing a go struct tag, not a struct field name, considered as a breaking API change?
As updateConfig is a fairly new feature, I don't have much concern but want to confirm.

sedefsavas · 2022-05-13T11:56:36Z

This is a breaking change, we'll need to fix in the next major release.

pydctw · 2022-05-13T20:55:27Z

/hold

richardcase · 2022-06-08T11:07:39Z

This is a breaking change, we'll need to fix in the next major release.

I added this as a link in the v1beta2 issue for tracking

k8s-triage-robot · 2022-09-06T11:50:56Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Skarlso · 2022-09-06T13:02:54Z

/remove-lifecycle stale

Ankitasw · 2022-09-06T13:47:33Z

/remove-lifecycle stale

I think we should keep lifecycle as is 😄 authors can take necessary action, maybe revive PR, or it will get closed automatically.

k8s-triage-robot · 2022-10-06T14:15:26Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Ankitasw · 2022-10-28T08:06:51Z

Since we have v1beta2 APIs
/unhold
/lgtm
/approve

k8s-ci-robot · 2022-10-28T08:07:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ankitasw · 2022-10-28T08:14:38Z

/hold
/test pull-cluster-api-provider-aws-e2e
until test passes.

Ankitasw · 2022-10-28T09:58:47Z

@phoban01 As verify job is failing, it requires make generate target to be run locally and then push the changes again.

Signed-off-by: Piaras Hoban <phoban01@gmail.com>

Skarlso · 2022-11-06T14:03:50Z

exp/api/v1beta1/types.go

@@ -276,5 +276,5 @@ type UpdateConfig struct {
 	// +optional
 	// +kubebuilder:validation:Maximum=100
 	// +kubebuilder:validation:Minimum=1
-	MaxUnavailablePercentage *int `json:"maxUnavailablePrecentage,omitempty"`
+	MaxUnavailablePercentage *int `json:"maxUnavailablePercentage,omitempty"`


Is this technically a breaking change? If someone used this with the incorrect spelling and uses the new version it wouldn't recognise that setting.

I'm think that we might have to introduce an intentionally misspelled version deprecate this one and redirect to the correctly spelled one. Unless people think that it's not necessary. 😁

This is a breaking change yes.

Right, I didn't read the previous comments. 🤦

Err... so can we merge this now? Since we had 2.0.0 sort of..? @richardcase ?

I also thought did we need a new struct field to force conversion, but the fuzzing tests would've picked this up.

I agree, as we are bumping the API version this breaking change is ok to go into 2.0.0. So

/lgtm

richardcase · 2022-11-07T08:57:07Z

Running the e2e again before unholding:

/test pull-cluster-api-provider-aws-e2e

Ankitasw · 2022-11-07T12:06:30Z

/unhold

…machinepool-spec-typo" The change should have been made to v1beta2, but was made to v1beta1 by mistake. This reverts commit dd1e449, reversing changes made to 71f07ab.

…breaking-change Revert "Merge pull request #3467 from phoban01/fix-awsmachinepool-spec typo"

k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 12, 2022

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 12, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2022

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2022

k8s-ci-robot requested review from Ankitasw and dthorsen May 12, 2022 09:26

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 12, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2022

richardcase mentioned this pull request Jun 8, 2022

v1beta2 API Changes #2355

Closed

4 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 6, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2022

k8s-ci-robot assigned Ankitasw Oct 28, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2022

struct tag for UpdateConfig should read maxUnavailablePercentage

ba05d77

Signed-off-by: Piaras Hoban <phoban01@gmail.com>

phoban01 force-pushed the fix-awsmachinepool-spec-typo branch from 9a1971f to ba05d77 Compare November 6, 2022 13:16

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2022

Skarlso reviewed Nov 6, 2022

View reviewed changes

k8s-ci-robot assigned richardcase Nov 7, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022

k8s-ci-robot merged commit dd1e449 into kubernetes-sigs:main Nov 7, 2022

k8s-ci-robot added this to the v1.x milestone Nov 7, 2022

phoban01 deleted the fix-awsmachinepool-spec-typo branch November 7, 2022 16:23

dlipovetsky mentioned this pull request Nov 8, 2022

Revert "Merge pull request #3467 from phoban01/fix-awsmachinepool-spec typo" #3825

Merged

4 tasks

k8s-ci-robot added a commit that referenced this pull request Nov 8, 2022

Merge pull request #3825 from dlipovetsky/dlipovetsky/revert-v1beta1-…

ca64938

…breaking-change Revert "Merge pull request #3467 from phoban01/fix-awsmachinepool-spec typo"

dlipovetsky mentioned this pull request Nov 8, 2022

Fix typo in UpdateConfig field, from maxUnavailablePrecentage to maxUnavailablePercentage #3830

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typo in AWSManagedMachinePool UpdateConfig #3467

Fix typo in AWSManagedMachinePool UpdateConfig #3467

phoban01 commented May 12, 2022

linux-foundation-easycla bot commented May 12, 2022 •

edited

Loading

k8s-ci-robot commented May 12, 2022

k8s-ci-robot commented May 12, 2022

k8s-ci-robot commented May 12, 2022

pydctw commented May 12, 2022

pydctw commented May 12, 2022

sedefsavas commented May 13, 2022

pydctw commented May 13, 2022

richardcase commented Jun 8, 2022

k8s-triage-robot commented Sep 6, 2022

Skarlso commented Sep 6, 2022

Ankitasw commented Sep 6, 2022

k8s-triage-robot commented Oct 6, 2022

Ankitasw commented Oct 28, 2022

k8s-ci-robot commented Oct 28, 2022

Ankitasw commented Oct 28, 2022 •

edited

Loading

Ankitasw commented Oct 28, 2022

Skarlso Nov 6, 2022

phoban01 Nov 6, 2022

Skarlso Nov 6, 2022

richardcase Nov 7, 2022

richardcase commented Nov 7, 2022

Ankitasw commented Nov 7, 2022

Fix typo in AWSManagedMachinePool UpdateConfig #3467

Fix typo in AWSManagedMachinePool UpdateConfig #3467

Conversation

phoban01 commented May 12, 2022

linux-foundation-easycla bot commented May 12, 2022 • edited Loading

k8s-ci-robot commented May 12, 2022

k8s-ci-robot commented May 12, 2022

k8s-ci-robot commented May 12, 2022

pydctw commented May 12, 2022

pydctw commented May 12, 2022

sedefsavas commented May 13, 2022

pydctw commented May 13, 2022

richardcase commented Jun 8, 2022

k8s-triage-robot commented Sep 6, 2022

Skarlso commented Sep 6, 2022

Ankitasw commented Sep 6, 2022

k8s-triage-robot commented Oct 6, 2022

Ankitasw commented Oct 28, 2022

k8s-ci-robot commented Oct 28, 2022

Ankitasw commented Oct 28, 2022 • edited Loading

Ankitasw commented Oct 28, 2022

Skarlso Nov 6, 2022

Choose a reason for hiding this comment

phoban01 Nov 6, 2022

Choose a reason for hiding this comment

Skarlso Nov 6, 2022

Choose a reason for hiding this comment

richardcase Nov 7, 2022

Choose a reason for hiding this comment

richardcase commented Nov 7, 2022

Ankitasw commented Nov 7, 2022

linux-foundation-easycla bot commented May 12, 2022 •

edited

Loading

Ankitasw commented Oct 28, 2022 •

edited

Loading