Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #3467 from phoban01/fix-awsmachinepool-spec typo" #3825

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Revert "Merge pull request #3467 from phoban01/fix-awsmachinepool-spec typo" #3825

merged 1 commit into from
Nov 8, 2022

Conversation

dlipovetsky
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
The change in #3467 should have been made to v1beta2, but was made to v1beta1 by mistake.

Thanks to @pydctw for spotting the mistake!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@dlipovetsky
Revert "Merge pull request kubernetes-sigs#3467 from phoban01/fix-aws…
e350899 
…machinepool-spec-typo"

The change should have been made to v1beta2, but was made to v1beta1 by
mistake.

This reverts commit dd1e449, reversing
changes made to 71f07ab.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2022
@richardcase
Copy link
Member

As well as the v1beta1 revert it's probably worth reapplying the change in v1beta2 at the same time. Wdyt?

And thank you @pydctw for spotting this mistake.

@Skarlso
Copy link
Contributor

Skarlso commented Nov 8, 2022

OMG. 🤦

@Skarlso
Copy link
Contributor

Skarlso commented Nov 8, 2022

/retest

@Skarlso
Copy link
Contributor

Skarlso commented Nov 8, 2022 •
edited
Loading

What's up with the tests? I can't see any logs or errors.

@Ankitasw
Copy link
Member

Ankitasw commented Nov 8, 2022

again something to do with prow i guess.

@Ankitasw
Copy link
Member

Ankitasw commented Nov 8, 2022

/retest

@Ankitasw
Copy link
Member

Ankitasw commented Nov 8, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@dlipovetsky
Copy link
Contributor Author

As well as the v1beta1 revert it's probably worth reapplying the change in v1beta2 at the same time. Wdyt?

I will add a commit for v1beta1 to this PR.

@k8s-ci-robot k8s-ci-robot merged commit ca64938 into kubernetes-sigs:main Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Nov 8, 2022
@dlipovetsky
Copy link
Contributor Author

Nevermind, this was merged. I'll open a separate PR with the v1beta2 change.

@Ankitasw
Copy link
Member

Ankitasw commented Nov 8, 2022

Yeah I was under the impression that you would open a separate PR 😓 sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthorsen dthorsen Awaiting requested review from dthorsen

@pydctw pydctw Awaiting requested review from pydctw

Assignees

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dlipovetsky @richardcase @Skarlso @Ankitasw @k8s-ci-robot