Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump CAPI to 1.8.6 #5249

Merged
merged 1 commit into from
Jan 29, 2025
Merged

🌱 Bump CAPI to 1.8.6 #5249

merged 1 commit into from
Jan 29, 2025

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Dec 11, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Brings CAPI to 1.8.6 specifically for PRs kubernetes-sigs/cluster-api#11303 and kubernetes-sigs/cluster-api#11478

This appears to address on-going failures we see in CAPA CI where the capa-e2e.[It] [unmanaged] [Cluster API Framework] Self Hosted Spec Should pivot the bootstrap cluster to a self-hosted cluster
case has been failing on the Kubernetes 1.29.8 to 1.29.9 step continuously.

My investigations of the logs showed that the most obvious errors were with webhooks during this step, something mentioned in kubernetes-sigs/cluster-api#11133

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Fully fixing the periodic failures will probably need #5242 and #5239, but I think the failures addressed by the CAPI updates are the most common.

Checklist:

Release note:

Upgrade to CAPI 1.8.6

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority labels Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2024
@nrb nrb marked this pull request as ready for review December 11, 2024 22:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@nrb
Copy link
Contributor Author

nrb commented Dec 11, 2024

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 11, 2024
@richardcase
Copy link
Member

@damdo
Copy link
Member

damdo commented Dec 12, 2024

Will need a retitle to 1.8.6

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2024
@nrb nrb changed the title 🌱 Bump CAPI to 1.8.5 🌱 Bump CAPI to 1.8.6 Dec 12, 2024
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
Copy link
Contributor Author

nrb commented Dec 12, 2024

/test pull-cluster-api-provider-aws-e2e

@damdo
Copy link
Member

damdo commented Jan 28, 2025

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @richardcase @AndiDog

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-build-docker
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-build-docker
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Copy link
Contributor Author

nrb commented Jan 28, 2025

/test pull-cluster-api-provider-aws-e2e-eks

last call sat on pending for 2 hours, can't see it on the prow dashboard at all.

@damdo
Copy link
Member

damdo commented Jan 28, 2025

It's pending probably because other eks jobs are running, only one is allowed at the same time IIUC.

@damdo
Copy link
Member

damdo commented Jan 29, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member

Both the e2e tests passed.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit cc12c52 into kubernetes-sigs:main Jan 29, 2025
21 checks passed
@damdo
Copy link
Member

damdo commented Jan 30, 2025

Do we want to back port to 2.7?

@nrb
Copy link
Contributor Author

nrb commented Jan 30, 2025

/cherry-pick release-2.7

@k8s-infra-cherrypick-robot

@nrb: new pull request created: #5328

In response to this:

/cherry-pick release-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants