Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] 🌱 test: add PreWaitForControlplaneToBeUpgraded to ClusterUpgradeConformanceSpec #11303

Merged

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:

Manual cherry-pick of #11145

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

…rmanceSpec (kubernetes-sigs#11145)

* test: add PreWaitForControlplaneToBeUpgraded to ClusterUpgradeConformanceSpec

* test: add template for kcp-pre-drain

* test: adjust multi-controlplane quickstart test to check for all nodes and kube-proxy being healthy via a pre-drain hook

* lint fix

* Review fixes

* review fixes

* review fixes

* review fix
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-release-1-8

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Oct 18, 2024
@chrischdi
Copy link
Member

/lgtm
/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-area PR is missing an area label labels Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6eb86715d49444231952fd049e2db0c7fc24b0a5

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-release-1-8

@k8s-ci-robot k8s-ci-robot merged commit 59ec354 into kubernetes-sigs:release-1.8 Oct 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants