Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add v1beta1 API types #1047

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

hidekazuna
Copy link
Contributor

What this PR does / why we need it:

Add v1beta1 API types

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1046

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

This should be merged after #1041

TODOs:

  • if necessary:
    • includes documentation

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2021
@netlify
Copy link

netlify bot commented Nov 13, 2021

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 6ddafd8

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6194b6d61f73ea00079e04d6

😎 Browse the preview: https://deploy-preview-1047--kubernetes-sigs-cluster-api-openstack.netlify.app

@hidekazuna hidekazuna force-pushed the v1beta1 branch 4 times, most recently from 0e5365f to a577eb9 Compare November 14, 2021 06:06
@hidekazuna
Copy link
Contributor Author

PTAL @sbueringer @jichenjc

@hidekazuna hidekazuna force-pushed the v1beta1 branch 3 times, most recently from bdc5e40 to 0d04913 Compare November 17, 2021 07:20
@hidekazuna
Copy link
Contributor Author

@jichenjc can we merge this? This PR is blocking API change.

@jichenjc
Copy link
Contributor

/lgtm
/hold cancel

ok let's merge this first and see how we can move forward

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 753fb4d into kubernetes-sigs:main Nov 18, 2021
@hidekazuna hidekazuna deleted the v1beta1 branch November 22, 2021 05:02
@mdbooth mdbooth mentioned this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add v1beta1 API types
3 participants