-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add v1beta1 API types #1047
✨ Add v1beta1 API types #1047
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hidekazuna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: 6ddafd8 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6194b6d61f73ea00079e04d6 😎 Browse the preview: https://deploy-preview-1047--kubernetes-sigs-cluster-api-openstack.netlify.app |
0e5365f
to
a577eb9
Compare
PTAL @sbueringer @jichenjc |
bdc5e40
to
0d04913
Compare
@jichenjc can we merge this? This PR is blocking API change. |
/lgtm ok let's merge this first and see how we can move forward |
What this PR does / why we need it:
Add v1beta1 API types
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1046
Special notes for your reviewer:
This should be merged after #1041
TODOs:
/hold