Implementation of Conditions feature in Openstack Machine Controller #972

swapnilbabladkar · 2021-08-18T08:27:57Z

Changes made in the following files:

v1alpha3 - openstackmachine_types.go , conditions_consts.go
v1alpha4 - openstackmachine_types.go , conditions_consts.go
controllers - openstackmachine_controller.go

What this PR does / why we need it:
This a work in progress for implemnting conditions feature for Cluster API Openstack - Machine controller

**Which issue(s) this PR fixes format, will close the issue(s) when PR gets merged)*:
#832

/hold

k8s-ci-robot · 2021-08-18T08:28:04Z

Welcome @swapnilbabladkar!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-08-18T08:28:04Z

Hi @swapnilbabladkar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swapnilbabladkar · 2021-08-18T08:38:44Z

Please provide with a /ok-to-test label

jichenjc · 2021-08-18T08:46:16Z

/ok-to-test

Merge branch 'test' of https://github.com/swapnilbabladkar/cluster-api-provider-openstack into test

jichenjc · 2021-08-19T02:10:30Z

is this duplicate to #952 ?

netlify · 2021-09-13T05:56:36Z

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: d1a845f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61a09acf15d8590007f118e7

😎 Browse the preview: https://deploy-preview-972--kubernetes-sigs-cluster-api-openstack.netlify.app

swapnilbabladkar · 2021-09-13T05:58:30Z

is this duplicate to #952 ?

#952 can be closed, changes can be tracked on this PR

…condition_const to conditions_consts

hidekazuna · 2021-10-07T02:41:50Z

@swapnilbabladkar Many unused constants still exist. Please add constants we use only. I think we do not need conditions for v1alpha3. Can you remove from v1alpha3?

- Removed conditions from v1alpha3 - Conditions support for following : InstanceRunningCondition InstanceNotFoundReason InstanceProvisionFailedReason WaitingForClusterInfrastructureReason WaitingForBootstrapDataReason - Changed Machine to Instance in conditions

swapnilbabladkar · 2021-10-08T07:13:29Z

@swapnilbabladkar Many unused constants still exist. Please add constants we use only. I think we do not need conditions for v1alpha3. Can you remove from v1alpha3?

Yes I now have only the constants being used in conditions for Machine. Also I have removed conditions from v1alpha3 in the latest commit : ac3a67e.

Thanks

swapnilbabladkar · 2021-10-14T13:33:35Z

Please review changes

hidekazuna · 2021-10-18T02:41:27Z

@swapnilbabladkar Still PR includes api/v1alpha3/openstackmachine_types.go. Please do not update api/v1alpha3/openstackmachine_types.go

hidekazuna · 2021-10-26T00:48:07Z

@swapnilbabladkar updated PR, but still api/v1alpha3/openstackmachine_types.go updated.

tobiasgiese

Please squash your commits before merging

tobiasgiese · 2021-10-31T09:46:19Z

api/v1alpha3/openstackmachine_types.go

@@ -126,6 +127,21 @@ type OpenStackMachineStatus struct {
 	// controller's output.
 	// +optional
 	FailureMessage *string `json:"errorMessage,omitempty"`
+


Please don't update the v1alpha3. We're not going to release (at least to my understanding) any new v1alpha3 version.

k8s-ci-robot · 2021-10-31T09:48:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swapnilbabladkar
To complete the pull request process, please assign neolit123 after the PR has been reviewed.
You can assign the PR to them by writing /assign @neolit123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Removal of conditions support for v1alpha3 - Addition of conditions instanceStatus.State() switch statement in controllers/openstackmachine_controller.go

hidekazuna · 2021-11-18T04:57:19Z

@swapnilbabladkar v1beta1 API is added(#1047 ). Please update this PR to change v1beta1 API.

k8s-ci-robot · 2021-11-26T09:11:15Z

@swapnilbabladkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-openstack-build	`d1a845f`	link	true	`/test pull-cluster-api-provider-openstack-build`
pull-cluster-api-provider-openstack-test	`d1a845f`	link	true	`/test pull-cluster-api-provider-openstack-test`
pull-cluster-api-provider-openstack-e2e-test	`d1a845f`	link	true	`/test pull-cluster-api-provider-openstack-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hidekazuna

@swapnilbabladkar Still working on this?

hidekazuna · 2021-12-07T00:34:39Z

api/v1alpha4/condition_consts.go

@@ -0,0 +1,35 @@
+/*


Now that v1beta1 is created, add api/v1beta1/condition_consts.go instead of this,please.

hidekazuna · 2021-12-07T00:35:18Z

api/v1alpha4/openstackmachine_types.go

@@ -19,6 +19,7 @@ package v1alpha4
 import (


Now that v1beta1 is created, update api/v1beta1/openstackmachine_types.go instead of this, please.

hidekazuna · 2021-12-07T00:36:31Z

api/v1alpha4/zz_generated.deepcopy.go

@@ -684,6 +684,13 @@ func (in *OpenStackMachineStatus) DeepCopyInto(out *OpenStackMachineStatus) {
 		*out = new(string)


After add or update files under api/v1beta1/ directory, you need to run make generate again.

k8s-ci-robot · 2022-03-03T05:36:27Z

@swapnilbabladkar: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tobiasgiese · 2022-05-09T06:49:43Z

@swapnilbabladkar are you still working on this PR?

tobiasgiese · 2022-07-02T14:25:40Z

Closing this PR, #1288 will replace it

[WIP] Implemntation of Conditions feature in CAPO

aa281b7

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2021

k8s-ci-robot requested review from prankul88 and sbueringer August 18, 2021 08:28

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2021

swapnilbabladkar added 3 commits August 19, 2021 00:55

[WIP] Implemntation of Conditions feature in CAPO

3046a99

[WIP] Implemntation of Conditions feature in CAPO

8da6773

Merge branch 'test' of https://github.com/swapnilbabladkar/cluster-api-provider-openstack into test

[WIP] Implemntation of Conditions feature in CAPO

feb5851

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2021

Merge branch 'master' into test

f31eb82

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2021

swapnilbabladkar added 7 commits September 13, 2021 11:40

[WIP] - Fixes to machine controller for adding conditions

f702ab3

[WIP] - Fixes to machine controller for adding conditions

46c8181

[WIP] - Fixes to machine controller for adding conditions

82db36a

[WIP] - Fixes to machine controller for adding conditions

aaa4f23

[WIP] - Fixes to machine controller for adding conditions

87ce61f

[WIP] - Fixes to machine controller for adding conditions

8f204c6

[WIP] - Fixes to machine controller for adding conditions

6e06720

swapnilbabladkar and others added 3 commits October 6, 2021 13:02

Removing unused varailbes from constants

7ca2a31

Support for conditions in machine not running state, name change for …

51cbf77

…condition_const to conditions_consts

Fixing syntax for machinecontroller

bac8fe7

swapnilbabladkar force-pushed the test branch from fb75912 to bac8fe7 Compare October 6, 2021 07:32

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 6, 2021

Fixes for gofmt with conditions file

1548ca1

swapnilbabladkar force-pushed the test branch from 486f044 to 1548ca1 Compare October 18, 2021 10:21

hidekazuna mentioned this pull request Oct 26, 2021

cluster-api v1beta1 adoption ? #1024

Closed

tobiasgiese requested changes Oct 31, 2021

View reviewed changes

Fixes as follows :

27f6a56

- Removal of conditions support for v1alpha3 - Addition of conditions instanceStatus.State() switch statement in controllers/openstackmachine_controller.go

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021

Merge branch 'main' into test

d1a845f

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2021

hidekazuna suggested changes Dec 7, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2022

apricote mentioned this pull request Jun 30, 2022

✨ Conditions for OpenStackMachines #1288

Merged

2 tasks

tobiasgiese closed this Jul 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of Conditions feature in Openstack Machine Controller #972

Implementation of Conditions feature in Openstack Machine Controller #972

swapnilbabladkar commented Aug 18, 2021

k8s-ci-robot commented Aug 18, 2021

k8s-ci-robot commented Aug 18, 2021

swapnilbabladkar commented Aug 18, 2021

jichenjc commented Aug 18, 2021

jichenjc commented Aug 19, 2021

netlify bot commented Sep 13, 2021 •

edited

Loading

swapnilbabladkar commented Sep 13, 2021

hidekazuna commented Oct 7, 2021

swapnilbabladkar commented Oct 8, 2021

swapnilbabladkar commented Oct 14, 2021

hidekazuna commented Oct 18, 2021

hidekazuna commented Oct 26, 2021

tobiasgiese left a comment

tobiasgiese Oct 31, 2021

k8s-ci-robot commented Oct 31, 2021

hidekazuna commented Nov 18, 2021

k8s-ci-robot commented Nov 26, 2021

hidekazuna left a comment

hidekazuna Dec 7, 2021

hidekazuna Dec 7, 2021

hidekazuna Dec 7, 2021

k8s-ci-robot commented Mar 3, 2022

tobiasgiese commented May 9, 2022

tobiasgiese commented Jul 2, 2022

		@@ -684,6 +684,13 @@ func (in OpenStackMachineStatus) DeepCopyInto(out OpenStackMachineStatus) {
		*out = new(string)

Implementation of Conditions feature in Openstack Machine Controller #972

Implementation of Conditions feature in Openstack Machine Controller #972

Conversation

swapnilbabladkar commented Aug 18, 2021

k8s-ci-robot commented Aug 18, 2021

k8s-ci-robot commented Aug 18, 2021

swapnilbabladkar commented Aug 18, 2021

jichenjc commented Aug 18, 2021

jichenjc commented Aug 19, 2021

netlify bot commented Sep 13, 2021 • edited Loading

swapnilbabladkar commented Sep 13, 2021

hidekazuna commented Oct 7, 2021

swapnilbabladkar commented Oct 8, 2021

swapnilbabladkar commented Oct 14, 2021

hidekazuna commented Oct 18, 2021

hidekazuna commented Oct 26, 2021

tobiasgiese left a comment

Choose a reason for hiding this comment

tobiasgiese Oct 31, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 31, 2021

hidekazuna commented Nov 18, 2021

k8s-ci-robot commented Nov 26, 2021

hidekazuna left a comment

Choose a reason for hiding this comment

hidekazuna Dec 7, 2021

Choose a reason for hiding this comment

hidekazuna Dec 7, 2021

Choose a reason for hiding this comment

hidekazuna Dec 7, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 3, 2022

tobiasgiese commented May 9, 2022

tobiasgiese commented Jul 2, 2022

netlify bot commented Sep 13, 2021 •

edited

Loading