-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Instance create timeout is in minutes #1267
📖 Instance create timeout is in minutes #1267
Conversation
Mention that the value of `CLUSTER_API_OPENSTACK_INSTANCE_CREATE_TIMEOUT` must be set in minutes.
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @pierreprinetti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve thanks, totally agree that it was misleading |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti, tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Am I the one who should remove the /hold? |
You can, sure. But we can as well 🙂 |
…on_timeout_docs 📖 Instance create timeout is in minutes
Mention that the value of
CLUSTER_API_OPENSTACK_INSTANCE_CREATE_TIMEOUT
must be set in minutes.What this PR does / why we need it:
In the user documentation, it was not clear that the value passed as
CLUSTER_API_OPENSTACK_INSTANCE_CREATE_TIMEOUT
is interpreted as minutes (as opposed to seconds, for example).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1266
Special notes for your reviewer:
TODOs:
/hold