🌱 Update golangci-lint (v1.46.2 -> v1.50.0), remove deprecated linters

[oscr]

What this PR does / why we need it:

• Updates golangci-lint version (v2.46.2 -> v1.49.0)
• Removed deprecated linters and configuration
  • deadcode
  • ifshort
  • structcheck
  • varcheck
• Fixes or adds //nolints.

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	940af7d
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6342992f053cc90007b155ea
😎 Deploy Preview	https://deploy-preview-1342--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[seanschneeweiss]

Can you adopt the title and replace v2.46.2 with v1.46.2.

Maybe we can also enable some linters as they did in CAPI: kubernetes-sigs/cluster-api#7208

[tobiasgiese]

/retitle 🌱 Update golangci-lint (v2.46.2 -> v2.49.0), remove deprecated linters

Edit: oops 😅

[tobiasgiese]

/retitle 🌱 Update golangci-lint (v1.46.2 -> v1.49.0), remove deprecated linters

[oscr]

It's not easy with all the different version numbers 😓 Thanks for the fix @tobiasgiese 🚀

[jichenjc]

/lgtm

[oscr]

Just bumped the golangci-lint version since a new version has been released since the pr was created.

[mdbooth]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, oscr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jichenjc]

/lgtm

[tobiasgiese]

Maybe we can also enable some linters as they did in CAPI: kubernetes-sigs/cluster-api#7208

@oscr Can you say something about the open suggestion from @seanschneeweiss?

[mdbooth]

Maybe we can also enable some linters as they did in CAPI: kubernetes-sigs/cluster-api#7208

@oscr Can you say something about the open suggestion from @seanschneeweiss?

@tobiasgiese I saw that but thought they could be added separately. Would you like me to remove the approve until it's answered?

[tobiasgiese]

Would you like me to remove the approve until it's answered?

It's okay for me to keep the approve label. If @oscr wants to remove the hold and create a follow-up PR it's totally fine for me :)

[oscr]

@tobiasgiese @mdbooth Thank you for pointing out the question. To be honest I just missed it. I suggest enabling additional linters in a separate pr. Some of them give a lot of findings. However I would be glad to do it.

[tobiasgiese]

Thanks for the clarification @oscr 🙂
/hold cancel