✨ Enable additional linters and metalinter checks. Fix findings

[oscr]

What this PR does / why we need it:

As discussed in #1342, this pr enables some additional linters that are also active in capi.

Enable new linters:

• asasalint
• bidichk
• dupword

Enable gocritic checks:

• diagnostic
• experimental
• performance

Fixes the findings

test/e2e/shared/context.go:85:2: Duplicate words (the) found (dupword)
	// BootstrapClusterProvider manages provisioning of the the bootstrap cluster to be used for the e2e tests.
	^
controllers/openstackmachine_controller.go:541:15: dynamicFmtString: use errors.New(string(err)) or fmt.Errorf("%s", string(err)) instead (gocritic)
	logger.Error(fmt.Errorf(string(err)), message.Error())
	             ^
controllers/openstackmachine_controller.go:424:6: emptyStringTest: replace `len(fp.PortID) != 0` with `fp.PortID != ""` (gocritic)
		if len(fp.PortID) != 0 {
		   ^
test/e2e/shared/context.go:40:2: commentedOutCode: may want to remove commented-out code (gocritic)
	// ctx.Lifecycle = DefaultGinkgoLifecycle()
	^

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	10f36f0
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/634d1b34579e970008a620ed
😎 Deploy Preview	https://deploy-preview-1359--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[jichenjc]

/lgtm

[tobiasgiese]

/approve

Thanks for the quick implementation @oscr! 🙂

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oscr, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oscr]

Formality question: who and when removes the hold? Am I expected to remove it? Because in earlier prs I've let the reviewers remove it, but I don't want to put more work on the reviewers than needed.

[jichenjc]

/hold cancel

usually it's a process to let more reviewers review for complicated PR
this should good enough and no need further review :)