-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Bump Gophercloud to v2 beta #1875
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
20c4725
to
2b24e82
Compare
This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sweet to get all new fixes :) |
Please note that we are likely to change all function signatures in |
Very much in favour of landing this once v2 lands, but not before, for example because of the possibility of changes like the above prior to release. I think gophercloud is pretty close to releasing that though, right? |
also curious about when v2 will land ,something like CPO will benefit as well if some enhancement can be adopted |
Yes although I'd measure the ETA in weeks rather than days or hours. |
@pierreprinetti sounds like we could update this one to use beta-2 but this will need a bunch of changes for ctx, right? |
correct beta.2 adds ctx everywhere |
New changes are detected. LGTM label has been removed. |
Updated to v2.0.0-beta.2. Calls to Gophercloud now use |
3008fd9
to
08c52a1
Compare
Co-Authored-By: Emilien Macchi <emacchi@redhat.com> Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
/test pull-cluster-api-provider-openstack-e2e-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Update Gophercloud + Utils to v2-beta
/hold