Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Upgrade Gophercloud to v2 #2107

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

pierreprinetti
Copy link
Contributor

@pierreprinetti pierreprinetti commented May 29, 2024

What this PR does / why we need it:

This patch upgrades Gophercloud to v2.0.0-rc.3.

This PR exercises CAPO's CI on v2 in preparation for the release.

/hold

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 29, 2024
Copy link

netlify bot commented May 29, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 3870213
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6682824117d9cf000876efb8
😎 Deploy Preview https://deploy-preview-2107--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pierreprinetti
Copy link
Contributor Author

I am not familiar with the test suite here. I suspect there's something wrong with the mocks?

@mdbooth
Copy link
Contributor

mdbooth commented May 30, 2024

This is going to be a merge conflict magnet. Lets aim to get this merged asap when gophercloud v2 is released, or @pierreprinetti is going to be babysitting it almost every day.

@pierreprinetti
Copy link
Contributor Author

pierreprinetti commented May 30, 2024

This is going to be a merge conflict magnet

@mdbooth yes indeed, I won't be updating this until it's time to merge. My goals with this PR are:

  1. to agree on how to tackle the bump. We already decided that we don't want to wire up context to the whole thing, and that's one decision less to make once it's actually time to merge;
  2. to see what CAPO's test machinery thinks;
  3. to timidly test whether you folks want to merge a RC instead of waiting for the release :)

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@EmilienM
Copy link
Contributor

EmilienM commented Jun 7, 2024

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 7, 2024
@pierreprinetti
Copy link
Contributor Author

/hold
Let me just check why Gopherclou2 is not passing CI in cloud-provider-openstack first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
@EmilienM
Copy link
Contributor

@pierreprinetti are we good now?

@pierreprinetti
Copy link
Contributor Author

The CI looks happy everywhere I have upgraded. Hence I'm proposing to release v2.0.0 on Monday. I will update the tag here in go.mod after it's done, and at that point I'll leave it to you guys to decide on the merge.

pierreprinetti and others added 2 commits July 1, 2024 12:17
Refactors the argument matching of expectCreateServer to take
gophercloud opts builders directly.
Also includes a couple of minor improvements to error reporting in the
event of a test failure.
@pierreprinetti
Copy link
Contributor Author

/hold cancel
v2.0.0 🎉

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@EmilienM
Copy link
Contributor

EmilienM commented Jul 1, 2024

/lgtm
/approve

Thanks for this work!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c197a1f into kubernetes-sigs:main Jul 1, 2024
9 checks passed
@pierreprinetti pierreprinetti deleted the g2 branch July 1, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants