-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Upgrade Gophercloud to v2 #2107
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7c0381d
to
ee70ffa
Compare
I am not familiar with the test suite here. I suspect there's something wrong with the mocks? |
This is going to be a merge conflict magnet. Lets aim to get this merged asap when gophercloud v2 is released, or @pierreprinetti is going to be babysitting it almost every day. |
@mdbooth yes indeed, I won't be updating this until it's time to merge. My goals with this PR are:
|
/approve |
/hold |
@pierreprinetti are we good now? |
The CI looks happy everywhere I have upgraded. Hence I'm proposing to release v2.0.0 on Monday. I will update the tag here in |
Refactors the argument matching of expectCreateServer to take gophercloud opts builders directly. Also includes a couple of minor improvements to error reporting in the event of a test failure.
/hold cancel |
/lgtm Thanks for this work! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This patch upgrades Gophercloud to v2.0.0-rc.3.
This PR exercises CAPO's CI on v2 in preparation for the release.
/hold