Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc for ssh key creation #405

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

jichenjc
Copy link
Contributor

ssh key is not needed anymore ...

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


ssh key is not needed anymore ...
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2019
@jichenjc
Copy link
Contributor Author

@sbueringer ,maybe you can add how to create CA in doc as well? how CA is created manually is something we need tell customer

@sbueringer
Copy link
Member

@sbueringer ,maybe you can add how to create CA in doc as well? how CA is created manually is something we need tell customer

Yup I can document it. Just to clarify. In my opinion the easiest way to create a CA is:

  • deploy Cluster CRD
  • wait 1-2 minutes
  • kubectl get cluster -o json | jq '.spec....CaCert' | base64 -d

Because the cluster actuator creates all CAs for us.

@jichenjc
Copy link
Contributor Author

@sbueringer ,maybe you can add how to create CA in doc as well? how CA is created manually is something we need tell customer

Yup I can document it. Just to clarify. In my opinion the easiest way to create a CA is:

  • deploy Cluster CRD
  • wait 1-2 minutes
  • kubectl get cluster -o json | jq '.spec....CaCert' | base64 -d

Because the cluster actuator creates all CAs for us.

fully agree, I don't know whether user want to use their own CA instead of created one... at least we can tell them auto create is preferred (??) and tell them how to create if they want... thanks

@sbueringer
Copy link
Member

@sbueringer ,maybe you can add how to create CA in doc as well? how CA is created manually is something we need tell customer

Yup I can document it. Just to clarify. In my opinion the easiest way to create a CA is:

  • deploy Cluster CRD
  • wait 1-2 minutes
  • kubectl get cluster -o json | jq '.spec....CaCert' | base64 -d

Because the cluster actuator creates all CAs for us.

fully agree, I don't know whether user want to use their own CA instead of created one... at least we can tell them auto create is preferred (??) and tell them how to create if they want... thanks

And with create your own you mean a few openssl commands to generate the ca and a private key and how to put them into the Cluster CRD, right?

@jichenjc
Copy link
Contributor Author

yes,that's my asking about.. thanks

@sbueringer
Copy link
Member

sbueringer commented Jul 22, 2019

/lgtm

Okay no problem. I'll open a PR for the CA doc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit b103053 into kubernetes-sigs:master Jul 22, 2019
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants