-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update doc for ssh key creation #405
Conversation
ssh key is not needed anymore ...
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer ,maybe you can add how to create CA in doc as well? how CA is created manually is something we need tell customer |
Yup I can document it. Just to clarify. In my opinion the easiest way to create a CA is:
Because the cluster actuator creates all CAs for us. |
fully agree, I don't know whether user want to use their own CA instead of created one... at least we can tell them auto create is preferred (??) and tell them how to create if they want... thanks |
And with create your own you mean a few openssl commands to generate the ca and a private key and how to put them into the Cluster CRD, right? |
yes,that's my asking about.. thanks |
/lgtm Okay no problem. I'll open a PR for the CA doc |
ssh key is not needed anymore ...
ssh key is not needed anymore ...
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: