Manual rebase on upstream #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ruct⚠️ move loadbalancer opts to struct
✨Refactor CreateInstance and CreateBastion
Downstream owners
Merge upstream kubernetes-sigs/cluster-api-provider-openstack
Update from kubernetes-sigs/cluster-api-provider-openstack
We currently require an explicit project_id field in the clouds.yaml. This conflicts with the usual fields for Application Credentials, as they already include a scope, and setting another conflicts with that. In this commit, we instead save the returned project_id from the initial auth api call, and pass it around to all services using the Scope struct.
…dential-support ✨ Support Application Credential auth
…v1alpha5⚠️ rename v1beta1 to v1alpha5
Previously we only waited for the loadbalancer to become active in case we created a new loadbalancer. Through this change, we will also wait for the loadbalancer to become active in case it already existed prior to the current reconcile.
kubeadm v1.24 removes the deprecated control-plane node label node-role.kubernetes.io/master. This PR introduces the new label node-role.kubernetes.io/control-plane in the CAPO tests and bumps the CAPI dependency for compatibility to nodes provisioned using kubeadm v1.24. * bumps CAPI to v1.1.3 * fixes k8s v1.24 compatibility * fixes periodics conformance ci job * adds tolerations and usage of the new control-plane node label * bumps e2e k8s version to v1.23.5 * bumps capo version to v1.23.2 Signed-off-by: Christian Schlotter <schlotterc@vmware.com>
…-link 📖 replace dead link for cloud.conf details
🏃 Add apricote as a reviewer
🏃Remove prankul88 as a reviewer
…1-1-3 🐛 bump CAPI to v1.1.3
Improve log message
…ore openstack data * fixes nil pointer when reconcileDelete gets executed a second time and security groups already got deleted * adds dump of existing ports at e2e tests
…formance-bastion-sec-nil 🐛 controllers/openstackcluster_controller.go fix nil pointer and dump openstack ports
🌱 Bump Gophercloud to v1.1.0
🌱 Add e2e clusterctl upgrade tests
We have an issue with our ubuntu image where we're not able to update the apt sources due to outdated public keys. To fix this issue we recreate the image via image-builder. Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
…ot/cherry-pick-1408-to-release-0.7 [release-0.7] 🐛 Update Ubuntu, CirrOS & Amphora image
…ot/cherry-pick-1405-to-release-0.7 [release-0.7] 🌱Release 0.7 patches
During this bump we must upgrade Golang to 1.19 as well. Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
This reverts commit 32a9fc9. Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
…ot/cherry-pick-1406-to-release-0.7 [release-0.7] ✨ Bump CAPI to v1.3.0
The ClusterctlUpgradeSpec contains a BeforeEach block so it cannot be nested in an It block. (cherry picked from commit b2bdc35)
Revert the workaround in clusterctl upgrade (cherry picked from commit c4229c9)
…atches 🌱 Backport E2E test fixes
…ot/cherry-pick-1421-to-release-0.7 [release-0.7] ✨Add lentzi90 to reviewers
…ot/cherry-pick-1424-to-release-0.7 [release-0.7] 🌱Bump CAPI to v1.3.1
in the initial reconciliation loop, a nil-pointer occurs if the cluster is configured with a bastion host. In this initial run the status field is still empty. Signed-off-by: Mario Constanti <mario@constanti.de>
…ot/cherry-pick-1445-to-release-0.7 [release-0.7] 🐛 fix nil-pointer in initial reconciliation loop with empty status field
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getoutput for openstackmachineinternalAZ special handling