-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1810400: Port CAPO to MAO API #90
Conversation
@Fedosin: This pull request references Bugzilla bug 1810400, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1539525
to
15b41d2
Compare
/retest |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Co-authored-by: Emilio Garcia <egarcia@redhat.com>
Co-authored-by: Mike Fedosin <mfedosin@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Fedosin: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#90. Bugzilla bug 1810400 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@iamemilio: #90 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…erate-yaml script (openshift#90) Referencing: openshift#88 :)
* Fix README.md Required option --provider-os was added to generate-yaml.sh in openshift#90. This patch fixes Cluster Creation section in README.md. * Apply suggestions from code review Co-Authored-By: hidekazuna <hidekazuna@gmail.com>
cluster-api has been moved to: http://github.com/openshift/machine-api-operator so we have to update the dependencies accordingly to allow node draining.
Along with it we stopped using deprecated
dep
tool to manage dependencies, and switched to go modules.