Bug 1824426: Allow to define primary ip address for machines #88
Conversation
|
/hold |
openshift-ci-robot
added
bugzilla/high
bugzilla/valid-bug
|
@Fedosin: This pull request references Bugzilla bug 1824426, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
approved
openshift-ci-robot
added
the
bugzilla/severity-high
|
@Fedosin: This pull request references Bugzilla bug 1824426, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@Fedosin: This pull request references Bugzilla bug 1824426, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
This patch allows to set primary ip address for the machine based on the primary network tag "<clusterInfraID>-primaryClusterNetwork". In the case of multiple attached networks this tag should allow CAPO to define which IP address to set as the primary one for machines. Now CAPO can't do this, because Neutron returns the list of networks in alphabetical order.
|
/test e2e-openstack |
|
/hold cancel |
openshift-ci-robot
removed
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Fedosin: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#88, openshift/installer#3483. Bugzilla bug 1824426 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@Fedosin: new pull request created: #96 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@adduarte: #88 failed to apply on top of branch "release-4.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…erate-yaml script (openshift#90) Referencing: openshift#88 :)
This patch allows to set primary ip address for the machine based on
the primary network tag
<clusterInfraID>-primaryClusterNetwork. In the case of multiple attached networks this tag should allow CAPO to define which IP address to set as the primary one for machines.Now CAPO can't do this, because Neutron returns the list of networks in alphabetical order.