Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.4] Bug 1832999: Migrate to MAO #98

Merged
merged 3 commits into from
Jul 3, 2020

Conversation

Fedosin
Copy link

@Fedosin Fedosin commented Jun 5, 2020

Cherry-picked from: #90

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 5, 2020
@openshift-ci-robot
Copy link

@Fedosin: This pull request references Bugzilla bug 1811400, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.4.z" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead
  • expected Bugzilla bug 1811400 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1811400: Migrate to MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@Fedosin Fedosin changed the title [release-4.4] Bug 1811400: Migrate to MAO [release-4.4] Bug 1832999: Migrate to MAO Jun 5, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jun 5, 2020
@openshift-ci-robot
Copy link

@Fedosin: This pull request references Bugzilla bug 1832999, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1810400 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1810400 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

[release-4.4] Bug 1832999: Migrate to MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 5, 2020
@iamemilio
Copy link

/lgtm
/hold until it passes

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@Fedosin
Copy link
Author

Fedosin commented Jun 7, 2020

/test e2e-openstack

2 similar comments
@Fedosin
Copy link
Author

Fedosin commented Jun 7, 2020

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Jun 8, 2020

/test e2e-openstack

@Fedosin
Copy link
Author

Fedosin commented Jun 8, 2020

/test e2e-openstack

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
Emilio Garcia and others added 2 commits June 8, 2020 16:17
Co-authored-by: Mike Fedosin <mfedosin@redhat.com>
Co-authored-by: Emilio Garcia <egarcia@redhat.com>
@mandre
Copy link
Member

mandre commented Jun 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@mandre
Copy link
Member

mandre commented Jun 8, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2020
@Fedosin
Copy link
Author

Fedosin commented Jun 18, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@bparees
Copy link

bparees commented Jun 18, 2020

@iamemilio this is passing, is it ready to be unheld and cherry pick approved?

@Fedosin
Copy link
Author

Fedosin commented Jun 19, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@Fedosin
Copy link
Author

Fedosin commented Jun 19, 2020

@bparees yes, it's ready to merge... I put the hold to make sure #102 passes the tests.
It would be really nice if we can merge them together, I mean #98 and the 4.4 backport of #102

@sdodson
Copy link
Member

sdodson commented Jun 19, 2020

/hold
unclear to me whether we're saying we need to include #102 in this change in order to prevent regressions or not

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@bparees
Copy link

bparees commented Jun 19, 2020

4.4.z boat is now full so this can be revisited next week i guess.

@pierreprinetti
Copy link
Member

@Fedosin
Do you think that the severity of this bug is really "medium"? Is it possible to stand up a 4.4 cluster on OpenStack without this patch?

CC @iamemilio

Cherry-picked from: openshift#101

Co-authored-by: Emilio Garcia <egarcia@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, iamemilio, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Fedosin,iamemilio,mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamemilio
Copy link

Holding until https://bugzilla.redhat.com/show_bug.cgi?id=1848755 is VERIFIED

@pierreprinetti
Copy link
Member

https://bugzilla.redhat.com/show_bug.cgi?id=1848755 is verified.

This is ready for the cherry-pick-approval! 🚀

@pierreprinetti
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit d8dc8cd into openshift:release-4.4 Jul 3, 2020
@openshift-ci-robot
Copy link

@Fedosin: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#98. Bugzilla bug 1832999 has been moved to the MODIFIED state.

In response to this:

[release-4.4] Bug 1832999: Migrate to MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants