[release-4.4]Bug 1832999: Migrate to MAO #94
Conversation
openshift-ci-robot
added
bugzilla/severity-high
|
@iamemilio: This pull request references Bugzilla bug 1811400, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
iamemilio
changed the title
openshift-ci-robot
removed
the
bugzilla/severity-high
|
@iamemilio: This pull request references Bugzilla bug 1810400, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-medium
|
/bugzilla refresh |
|
@iamemilio: This pull request references Bugzilla bug 1810400, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
iamemilio
changed the title
|
/bugzilla refresh |
|
@iamemilio: This pull request references Bugzilla bug 1832999, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@iamemilio: This pull request references Bugzilla bug 1832999, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@mandre: This pull request references Bugzilla bug 1832999, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/hold until openshift/release#8950 merges |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
openshift-ci-robot
added
the
do-not-merge/hold
| github.com/gophercloud/gophercloud v0.6.1-0.20191025185032-6ad562af8c1f | ||
| github.com/gophercloud/utils v0.0.0-20190124231947-9c3b9f2457ef | ||
| github.com/openshift/client-go v0.0.0-20200320150128-a906f3d8e723 | ||
| github.com/openshift/machine-api-operator v0.2.1-0.20200402110321-4f3602b96da3 |
There was a problem hiding this comment.
Yes, this is pulling from the 4.5 branch. We can't simply backport this kind of thing, need to do do the go get stuff separate from the application code.
|
/hold Bug causing MAO to fail |
Co-authored-by: Emilio Garcia <egarcia@redhat.com>
|
@iamemilio: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@iamemilio: This pull request references Bugzilla bug 1832999. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Move provider config getters to the provider ProviderConfig getters belong to the provider package as they are specific to the provider implementation and subject to versioning. This commits moves the providerConfig functions into the openstackproviderconfig package. Future patches will revisit other parts of this code * Partially implement Cluster Delete This commit starts the implementation of the cluster actuator. The Delete step doesn't do much at this stage but we'll complete the implementation soon. * Move the machine actuator under a new package Use a new package for the machine actuator so that we can group all the actuators based on their topology, rather than having long, weird, file names. * Dummy reconcile implementation This commits adds a basic implementation for the cluster's reconcile flow. Ideally, we'll be extending and improving this function over time as new things are added to the cluster status.
No description provided.