Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1843597: Revendor MAO and client-go #101

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

iamemilio
Copy link

updates MAO to match CAPA pin, and updates client-go for compatibility

@iamemilio iamemilio requested a review from Fedosin June 18, 2020 17:38
@openshift-ci-robot
Copy link

@iamemilio: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

revendor MAO and client-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@iamemilio
Copy link
Author

/cc @adduarte

Lets see if this can provision workers

@iamemilio iamemilio changed the base branch from release-4.5 to master June 18, 2020 17:46
@iamemilio iamemilio changed the title revendor MAO and client-go Bug 1843597: Revendor MAO and client-go Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 18, 2020
@openshift-ci-robot
Copy link

@iamemilio: This pull request references Bugzilla bug 1843597, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1843597: Revendor MAO and client-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [iamemilio,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a1f6e26 into openshift:master Jun 18, 2020
@openshift-ci-robot
Copy link

@iamemilio: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#101. Bugzilla bug 1843597 has been moved to the MODIFIED state.

In response to this:

Bug 1843597: Revendor MAO and client-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamemilio
Copy link
Author

/cherry-pick release-4.5

@openshift-cherrypick-robot

@iamemilio: new pull request created: #102

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fedosin added a commit to Fedosin/cluster-api-provider-openstack that referenced this pull request Jun 19, 2020
Cherry-picked from: openshift#101

Co-authored-by: Emilio Garcia <egarcia@redhat.com>
@morenod
Copy link

morenod commented Jun 22, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@morenod: Bugzilla bug 1843597 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
We should not update the cluster status until the clustergetter is
properly implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants