Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sriov Addons #173

Merged
merged 5 commits into from
Mar 30, 2021
Merged

Sriov Addons #173

merged 5 commits into from
Mar 30, 2021

Conversation

iamemilio
Copy link

@iamemilio iamemilio commented Mar 29, 2021 •
edited by openshift-ci-robot
Loading

Contains a number of bugfixes and features needed to fully support the OpenShift SR-IOV Operator.
Please see each commit for more details.

Fixes: OSASINFRA-2364

Emilio Garcia added 5 commits March 29, 2021 11:12
Dockerfile update to latest base image URL
530a751 
Origin images have moved to urls with the pattern: .../origin/<release
number>:tag.
Port Security
332d9c1 
Ports that are used with the OpenShift SR-IOV Operator need the
portSecurity disabled. This feature allows ports to optionally have
the security disabled. If left empty, they will be set to nova default.
<carry:778> Create Ports
363d2e9 
Allows users to define ports to be added as network interfaces to
machines.
Port Tag Bugfix
ab2bf9c 
Fixes port tag feature to include user tags.
Port Tagging
c313fe2 
Allow machine ports to be tagged.
@iamemilio iamemilio requested a review from adduarte March 29, 2021 16:18
@iamemilio
Copy link
Author

I just built a release image and installed this on PSI, and it succesfully deployed no-problem. This is ready to merge, the CI is just unstable.

@adduarte
Copy link

/lgtm

@iamemilio iamemilio mentioned this pull request Mar 29, 2021
Closed
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021
@adduarte
Copy link

/approve

1 similar comment
@iamemilio
Copy link
Author

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adduarte, iamemilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 314d5a2 into openshift:master Mar 30, 2021
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@flaper87 @pierreprinetti
Get user-data/startupScripts from secrets (openshift#173)
974b0e7 
This commit adds the ability to pass custom userData/startupScripts to
the machines using kubernetes secrets. The previous workflow that used
the machine-setup ConfigMap has been removed in favor of the new one.

Fixes openshift#158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

@mandre mandre Awaiting requested review from mandre

Assignees

@adduarte adduarte

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamemilio @adduarte @openshift-ci-robot @openshift-bot @openshift-merge-robot