[WIP] Bug 1942686: Extend trunk configuration to port level in machineset #176
Conversation
With the introduction of new technologies, like SR-IOV, it is required that the user have the ability to configured trunked and not-trunked ports for the same machines.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adduarte: This pull request references Bugzilla bug 1942686, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
|
@adduarte: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
you will have to extend the trunk create logic to the ports here as well. Currently they dont ever get trunked |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Closed in favor or #185 |
|
@adduarte: This pull request references Bugzilla bug 1942686. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not all the scenarios supported by CAPO require the manager to pull the kubeconfig configs from the nodes. Rather than failing due to missing ssh keys, we should just log the inability to pull the config file and continue with the execution. This is an interim solution until openshift#174 is resolved. Related to openshift#175
With the introduction of new technologies, like SR-IOV,
it is required that the user have the ability to
configure trunked and not-trunked ports for the same machines.