Bug 1948546: Port create bugs #175
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
iamemilio
changed the title
iamemilio
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
iamemilio
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@iamemilio: This pull request references Bugzilla bug 1943599, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@iamemilio: This pull request references Bugzilla bug 1943599, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: wjiangjay. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
reporting this upstream as well: kubernetes-sigs#834 |
|
/hold until this discussion is settled upstream |
openshift-ci-robot
added
the
do-not-merge/hold
iamemilio
changed the title
iamemilio
force-pushed
the
portCreateRaceConditions
branch
from
c5bdad0
to
50c947f
Compare
These fields need to be set by OpenStack, otherwise there is the potential to create severe errors. They also require admin/owner permission to set. They should not be exposed to end users at all.
There is duplicate logic on how ports for machine interfaces are created. This converts all portCreate calls to use a single private function to create ports and uses the same process for each of them.
Allowed address pairs and security groups are now removed from the port when the port security is disabled. This ensures that no nova errors occur since this is a hard requirement of diabling port security.
iamemilio
force-pushed
the
portCreateRaceConditions
branch
from
50c947f
to
4492710
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
The yaml for the vnic type required an argument "binding:vnicType" when it should have been "vnicType". The HostID had the same issue. We also created a struct for the FixedIPs to ensure the api remains camel case.
iamemilio
force-pushed
the
portCreateRaceConditions
branch
from
4492710
to
234638e
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
iamemilio
changed the title
openshift-ci-robot
removed
the
bugzilla/severity-medium
|
@iamemilio: This pull request references Bugzilla bug 1948546, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (juriarte@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/severity-high
|
@iamemilio: This pull request references Bugzilla bug 1948546, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (juriarte@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@iamemilio: All pull requests linked via external trackers have merged: Bugzilla bug 1948546 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not all the scenarios supported by CAPO require the manager to pull the kubeconfig configs from the nodes. Rather than failing due to missing ssh keys, we should just log the inability to pull the config file and continue with the execution. This is an interim solution until openshift#174 is resolved. Related to openshift#175
* Remove GetKubeConfig from the machine actuator `GetKubeConfig` is only needed in the deployer, therefore we can do away with the code we have in the machine actuator. This helps with issues openshift#174 and openshift#175 * Don't mount sshkeys on the manager's pod We've removed the last use for the sshkeys secret/mount in the manager's POD, which means we can now remove this code and stop mounting these keys. Fixes openshift#175 * Remove KeyPair related functions from the machine service We're not managing keypairs from the actuator anymore. The functions that used to manage keypairs have been removed in this commit.
There were a number of issues in the way we allowed users to create ports/interfaces for nodes through the machine API. This patch looks to clean them up to prevent race conditions or OpenStack errors that could cause a deployment to fail due to logical errors in cluster-api-provider-openstack.