Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1948546: Port create bugs #175

Merged

Commits on Apr 13, 2021

  1. Device Owner and Device ID unsafe

    These fields need to be set by OpenStack, otherwise there is the
    potential to create severe errors. They also require admin/owner
    permission to set. They should not be exposed to end users at all.
    Emilio Garcia committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    ece038f View commit details
    Browse the repository at this point in the history
  2. Unify Port Creation Logic

    There is duplicate logic on how ports for machine interfaces are
    created. This converts all portCreate calls to use a single private
    function to create ports and uses the same process for each of them.
    Emilio Garcia committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    a277eac View commit details
    Browse the repository at this point in the history
  3. Fix Port Security feature

    Allowed address pairs and security groups are now removed from the port
    when the port security is disabled. This ensures that no nova errors
    occur since this is a hard requirement of diabling port security.
    Emilio Garcia committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    223c5de View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Port Opts YAML did not follow proper conventions

    The yaml for the vnic type required an argument "binding:vnicType" when
    it should have been "vnicType". The HostID had the same issue. We also
    created a struct for the FixedIPs to ensure the api remains camel case.
    Emilio Garcia committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    234638e View commit details
    Browse the repository at this point in the history