OCPBUGS-1765: Apply noAllowedAddressPairs on intended subnets only #242
Conversation
Before this change, setting `noAllowedAddressPairs` on a machine-pool
network could have effect on a different network.
Given this example configuration:
```yaml
networks:
- filter: {}
noAllowedAddressPairs: false
subnets:
- filter: {}
uuid: primary-subnet-uuid
- filter: {}
noAllowedAddressPairs: true
subnets:
- filter: {}
uuid: other-subnet-uuid
primarySubnet: primary-subnet-uuid
```
The filter of the second network the array is empty. This means that its
`subnet` filter has to be applied without restrictions as to which
network it's sitting on. However, the absence of a network filter also
meant that the setting `noAllowedAddressPairs` would apply to all
networks.
With this change, `noAllowedAddressPairs` is applied on a subnet basis,
meaning that only ports created in the subnets resulting from the
further `subnet` filter actually have their allowed address pairs
removed.
openshift-ci-robot
added
jira/severity-moderate
|
@pierreprinetti: This pull request references Jira Issue OCPBUGS-1765, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/uncc stephenfin mdbooth |
openshift-ci
bot
requested review from
mandre
and removed request for
mdbooth and
stephenfin
|
@pierreprinetti: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@pierreprinetti: This pull request references Jira Issue OCPBUGS-1765, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@pierreprinetti: This pull request references Jira Issue OCPBUGS-1765, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@pierreprinetti: This pull request references Jira Issue OCPBUGS-1765, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: eurijon. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@pierreprinetti: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1765 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierreprinetti: new pull request created: #243 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Requesting the subnetID is very limiting as it requires to create subnets in advance and know the uuid. We allow for filtering netwoks and we should allow for filtering subnets too. This will make the API more consistent.
Before this change, setting
noAllowedAddressPairson a machine-pool network could have effect on a different network.Given this example configuration:
The filter of the second network the array is empty. This means that its
subnetfilter has to be applied without restrictions as to which network it's sitting on. However, the absence of a network filter also meant that the settingnoAllowedAddressPairswould apply to all networks.With this change,
noAllowedAddressPairsis applied on a subnet basis, meaning that only ports created in the subnets resulting from the furthersubnetfilter actually have their allowed address pairs removed.