Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1823487: Add ServerGroupName to OpenstackProviderSpec #97

Merged
merged 1 commit into from
May 26, 2020
Merged

Bug 1823487: Add ServerGroupName to OpenstackProviderSpec #97

merged 1 commit into from
May 26, 2020

Conversation

pierreprinetti
Copy link
Member

A server group with the corresponding name and "soft-anti-affinity"
policy will be created if it does not exist already.

@pierreprinetti
Add ServerGroupName to OpenstackProviderSpec
e94c6dd 
A server group with the corresponding name and "soft-anti-affinity"
policy will be created if it does not exist already.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@mandre
Copy link
Member

mandre commented May 26, 2020

/lgtm
/retest
/hold

Feel free to remove the hold when the tests are passing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mandre,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@pierreprinetti pierreprinetti changed the title Add ServerGroupName to OpenstackProviderSpec Bug 1823487: Add ServerGroupName to OpenstackProviderSpec May 26, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 26, 2020
@openshift-ci-robot
Copy link

@pierreprinetti: This pull request references Bugzilla bug 1823487, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1823487: Add ServerGroupName to OpenstackProviderSpec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 319a35b into openshift:master May 26, 2020
@openshift-ci-robot
Copy link

@pierreprinetti: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#97. Bugzilla bug 1823487 has been moved to the MODIFIED state.

In response to this:

Bug 1823487: Add ServerGroupName to OpenstackProviderSpec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bug1823487 branch May 26, 2020 11:22
@pierreprinetti pierreprinetti mentioned this pull request May 26, 2020
Merged
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@ainmosni @pierreprinetti
Add rudimentary cloud.conf support. (openshift#97)
dd8b838 
This patch adds rudimentary cloud provider support. It reuses the
credentials given to generate-yaml.sh.

This changes the following:

* This uses yq to parse clouds.yaml, either the supplied one or the
  generated one.
* It changes region to region_name in the generated clouds.yaml.
* It embeds the clouds.conf in the provider-components, base64 encoded
  so that there will be no indentation problems.
* It adds the cloud-provider and cloud-config arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre Awaiting requested review from mandre

@iamemilio iamemilio Awaiting requested review from iamemilio

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierreprinetti @mandre @openshift-ci-robot @openshift-merge-robot