-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1823487: Add ServerGroupName to OpenstackProviderSpec #97
Conversation
A server group with the corresponding name and "soft-anti-affinity" policy will be created if it does not exist already.
/lgtm Feel free to remove the hold when the tests are passing. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@pierreprinetti: This pull request references Bugzilla bug 1823487, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierreprinetti: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#97. Bugzilla bug 1823487 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch adds rudimentary cloud provider support. It reuses the credentials given to generate-yaml.sh. This changes the following: * This uses yq to parse clouds.yaml, either the supplied one or the generated one. * It changes region to region_name in the generated clouds.yaml. * It embeds the clouds.conf in the provider-components, base64 encoded so that there will be no indentation problems. * It adds the cloud-provider and cloud-config arguments.
A server group with the corresponding name and "soft-anti-affinity"
policy will be created if it does not exist already.