Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1823487: openstack: Pass the master server group by name #3655

Merged
merged 1 commit into from
May 29, 2020
Merged

Bug 1823487: openstack: Pass the master server group by name #3655

merged 1 commit into from
May 29, 2020

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented May 26, 2020 •
edited
Loading

Create the Control Plane server group in Terraform and pass the server
group by name, and not by UUID, in the machine spec.

/label platform/openstack
/cc mandre Fedosin iamemilio adduarte

Includes a CAPO bump to include ServerGroupName in the Machine spec: openshift/cluster-api-provider-openstack#97

@openshift-ci-robot openshift-ci-robot added platform/openstack bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels May 26, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1823487, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1823487: openstack: Delegate server group creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 26, 2020
@pierreprinetti
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 26, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1823487, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 26, 2020
@pierreprinetti
Copy link
Member Author

/retest

2 similar comments
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti pierreprinetti marked this pull request as draft May 27, 2020 10:48
@pierreprinetti
openstack: Pass the master server group by name
91d91a0 
Create the Control Plane server group in Terraform and pass the server
group by name, and not by UUID, in the machine spec.
@pierreprinetti pierreprinetti changed the title Bug 1823487: openstack: Delegate server group creation Bug 1823487: openstack: Pass the master server group by name May 27, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1823487, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1823487: openstack: Pass the master server group by name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

/retest

1 similar comment
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti pierreprinetti marked this pull request as ready for review May 27, 2020 14:47
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2020
@mandre
Copy link
Member

mandre commented May 27, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@pierreprinetti
Copy link
Member Author

/approve

@pierreprinetti
Copy link
Member Author

/assign @abhinavdahiya
for the CAPO bump

@abhinavdahiya
Copy link
Contributor

/assign @abhinavdahiya
for the CAPO bump

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 679760c into openshift:master May 29, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: All pull requests linked via external trackers have merged: openshift/installer#3655, openshift/cluster-api-provider-openstack#97. Bugzilla bug 1823487 has been moved to the MODIFIED state.

In response to this:

Bug 1823487: openstack: Pass the master server group by name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bug1823487 branch May 29, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

Assignees

@mandre mandre

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierreprinetti @openshift-ci-robot @mandre @abhinavdahiya @openshift-bot @openshift-merge-robot