-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create kubeconfig for each cluster in reconcile function #412
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
per issue 413 indicated, we need a masterip in order to create kubeconfig file.
per cluster-api changes, this is needed for provider to create and utilized by cluster-api manager container
if len(config.MasterIP) == 0 { | ||
return "", errors.New("MasterIP in cluster spec not set") | ||
} | ||
ip = config.MasterIP | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to merge this with this code here:
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/401/files#diff-266c339b51cf18a076cf106526357c53R70-R78
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this would be in the else branch if ManagedAPIServerLoadBalancer is set to false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, let's work on that patch first then rebase from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. I'll rebase mine
/lgtm |
…sigs#412) * Add masterip into clusterproviderspec per issue 413 indicated, we need a masterip in order to create kubeconfig file. * Create secret kubeconfig-<cluster> per cluster-api changes, this is needed for provider to create and utilized by cluster-api manager container
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #410
Fixes #413
Special notes for your reviewer:
Release note: