Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional description for DNS #497

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

jichenjc
Copy link
Contributor

I am working on my env and noticed that the new VM is not able to
start because my VM can't talk to openstack URL (which is web URI
instead of IP), so we need guide user to create this DNS explicility.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


I am working on my env and noticed that the new VM is not able to
start because my VM can't talk to openstack URL (which is web URI
instead of IP), so we need guide user to create this DNS explicility.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@sbueringer
Copy link
Member

Hm I'm a little bit confused when exactly this property is needed. I wasn't even aware the property exists until now and I did not set it in any of my clusters. (I'm also accessing OpenStack via URL not IP)

@jichenjc
Copy link
Contributor Author

it's needed. here's the reason :)

the network is created by our logic so if we pass the DNS param, the /etc/resolv.conf of openstack deployed VM will be updated to include the DNS location , my openstack URL is abc.com (different, but like this), not IP ,so when the kubeadm start, because it's openstack cloud provider, it's trying to reach the URL to get additional info, if the DNS is not set, then the URL might not be recognized so that the kubeadm/kubelet is not able to correctly start

@sbueringer
Copy link
Member

@jichenjc Never mind. I'm actually setting this property and forgot that I did :)

That explains why it works in my env

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2020
@sbueringer
Copy link
Member

/test pull-cluster-api-provider-openstack-test

@k8s-ci-robot k8s-ci-robot merged commit 7042181 into kubernetes-sigs:master Jan 25, 2020
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
I am working on my env and noticed that the new VM is not able to
start because my VM can't talk to openstack URL (which is web URI
instead of IP), so we need guide user to create this DNS explicility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants