Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if compute AZ is available #142

Closed
wants to merge 2 commits into from
Closed

check if compute AZ is available #142

wants to merge 2 commits into from

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Dec 8, 2020 •
edited
Loading

  • Update gophercloud/utils + deps to latest
  • Check if Availability Zone exists and is actually available

JIRA: OSASINFRA-2207

@EmilienM
[vendoring] update gophercloud/utils + deps
8a54432 
Updating vendoring for gophercloud/utils so we will be
able to get the new helper which validates that a Compute
Availability Zone exists and is actually available.

Commands run:
$ go get github.com/gophercloud/utils
$ go get github.com/gophercloud/gophercloud
$ go mod tidy
$ go mod vendor

Signed-off-by: Emilien Macchi <emilien@redhat.com>
@EmilienM
check if compute AZ is available
12dc858 
Before creating a machine in a given AZ, it'll check that the AZ
actually exists and is available.

JIRA: https://issues.redhat.com/browse/OSASINFRA-1848
Signed-off-by: Emilien Macchi <emilien@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mandre after the PR has been reviewed.
You can assign the PR to them by writing /assign @mandre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

@EmilienM: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/govet 12dc858 link /test govet
ci/prow/unit 12dc858 link /test unit
ci/prow/e2e-openstack 12dc858 link /test e2e-openstack
ci/prow/images 12dc858 link /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member Author

Closing for #143
Bumping gophercloud is a mess, from 0.6 to 0.14 seems nearly impossible or a lot of work; is it worth it? See #126

@EmilienM EmilienM closed this Dec 10, 2020
@EmilienM EmilienM deleted the jira/1848 branch December 10, 2020 21:58
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@YorikSar @pierreprinetti
Use realpath for path comparison in Makefile (openshift#142)
ef32ffd 
This prevents make from erroring if some part of $(GOPATH)/src is a
symlink and $(PWD) might already be canonical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilienM @openshift-ci-robot @openshift-merge-robot