-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make primary subnet a programatic part of provider spec #129
make primary subnet a programatic part of provider spec #129
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-openstack |
Ready for review: Because primary subnet is set in the install config, these changes are not problematic in the installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ensure the uuids are returned when there is no error finding the requested networks.
Instead of using tags on the subnet, we want the user to be able to have control over the primary subnet in a more standardized way. We are moving the functionality to the provider spec. In most use cases, this will be set automatically by the installer, however, this gives the user the ability to manually override it based on their use case.
/cc @mandre