make primary subnet a programatic part of provider spec #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-openstack |
iamemilio
changed the title
|
Ready for review: Because primary subnet is set in the install config, these changes are not problematic in the installer |
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
Ensure the uuids are returned when there is no error finding the requested networks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using tags on the subnet, we want the user to be able to have control over the primary subnet in a more standardized way. We are moving the functionality to the provider spec. In most use cases, this will be set automatically by the installer, however, this gives the user the ability to manually override it based on their use case.
/cc @mandre