Add alternative to OS image #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
sbueringer
reviewed
Jan 21, 2020
jichenjc
force-pushed
the
add_tips_images
branch
from
f283e9d
to
1e1619b
Compare
|
you are right, actually from test, the container run time, kubelet are included as well |
jichenjc
force-pushed
the
add_tips_images
branch
from
1e1619b
to
e346c7d
Compare
prankul88
reviewed
Jan 22, 2020
image builder is good but we may tip folks to use other potential easier way (learning curve perspective) to build an image.
jichenjc
force-pushed
the
add_tips_images
branch
from
e346c7d
to
20e1d2e
Compare
|
@prankul88 updated, thanks |
|
@jichenjc Thanks |
k8s-ci-robot
added
the
lgtm
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
image builder is good but we may tip folks to use other potential easier way (learning curve perspective) to build an image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image builder is good but we may tip folks to use other potential
easier way (learning curve perspective) to build an image.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: