-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream merge #231
Upstream merge #231
Conversation
The controller test suite was disabled due to missing kubebuilder assets. These are now installed before running the tests. A simple sanity check test is also added to confirm that envTest is working.
…ontroller-tests 🏃 Enable controller tests
🏃 Explain mutability of bastion configuration in CRD
Common network and security group handling between CreateBastion() and CreateInstance(). A principal advantage of this refactor is that it makes the marshalling of OpenStackMachineSpec and Instance respectively into an InstanceSpec a cheap operation which makes no API calls.
Refactor instance creation in machine controller and cluster controller (for the bastion) to call compute.CreateInstance() with an InstanceSpec.
…ruct⚠️ move loadbalancer opts to struct
✨Refactor CreateInstance and CreateBastion
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mdbooth: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
It is required to use security group UUIDs instead of their names at the machine yaml
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: