Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1724204: Set additional machine annotations/labels #55

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Bug 1724204: Set additional machine annotations/labels #55

merged 1 commit into from
Aug 20, 2019

Conversation

Fedosin
Copy link

@Fedosin Fedosin commented Aug 15, 2019 •
edited
Loading

This commit sets additional machine annotations/labels to get pretty machine output.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1724204

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2019
@Fedosin Fedosin changed the title Set additional machine annotations/labels Bug 1724204: Set additional machine annotations/labels Aug 15, 2019
@openshift-ci-robot
Copy link

@Fedosin: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1724204: Set additional machine annotations/labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 15, 2019
@openshift-ci-robot
Copy link

@Fedosin: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1724204: Set additional machine annotations/labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Author

Fedosin commented Aug 15, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2019
@Fedosin Fedosin force-pushed the set_annotations branch 2 times, most recently from e67f5b0 to 93c3d8d Compare August 15, 2019 23:53
@Fedosin
Copy link
Author

Fedosin commented Aug 16, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2019
@Fedosin
Copy link
Author

Fedosin commented Aug 16, 2019

Looks good:
$ oc get machines -A
NAMESPACE NAME STATE TYPE REGION ZONE AGE
openshift-machine-api ci-op-h300tjy1-kpkrv-master-0 ACTIVE m1.s2.xlarge moc-kzn nova 3m54s
openshift-machine-api ci-op-h300tjy1-kpkrv-master-1 ACTIVE m1.s2.xlarge moc-kzn nova 3m53s
openshift-machine-api ci-op-h300tjy1-kpkrv-master-2 ACTIVE m1.s2.xlarge moc-kzn nova 3m53s
openshift-machine-api ci-op-h300tjy1-kpkrv-worker-2s74t ACTIVE m1.s2.xlarge moc-kzn nova 2m45s
openshift-machine-api ci-op-h300tjy1-kpkrv-worker-6k99p ACTIVE m1.s2.xlarge moc-kzn nova 2m44s
openshift-machine-api ci-op-h300tjy1-kpkrv-worker-w9w6r ACTIVE m1.s2.xlarge moc-kzn nova 2m45s

@Fedosin Fedosin mentioned this pull request Aug 16, 2019
Merged
4 tasks
@Fedosin
Bug 1724204: Set additional machine annotations/labels
307f60f 
This commit sets additional machine annotations/labels to
get pretty machine output.
@mandre
Copy link
Member

mandre commented Aug 20, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@iamemilio
Copy link

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, iamemilio, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Fedosin,iamemilio,mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit 27c87ca into openshift:master Aug 20, 2019
@openshift-ci-robot
Copy link

@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1724204 has been moved to the MODIFIED state.

In response to this:

Bug 1724204: Set additional machine annotations/labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
racheljpg pushed a commit to racheljpg/cluster-api-provider-openstack that referenced this pull request Dec 20, 2023
@iamemilio @flaper87
Make providerConfig keys consistent (openshift#55)
2bac6a8 
Reference: kubernetes-sigs#44
Changes: The security_group and availability_zone keys are now lowerCamelCase
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@iamemilio @pierreprinetti
Make providerConfig keys consistent (openshift#55)
6b59a23 
Reference: kubernetes-sigs#44
Changes: The security_group and availability_zone keys are now lowerCamelCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@mandre mandre

@iamemilio iamemilio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fedosin @openshift-ci-robot @mandre @iamemilio @openshift-merge-robot