-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get values for CRD's additionalPrinterColumns from annotations and labels instead of machine provider config #360
Conversation
@ingvagabund could you also add OpenStack to the list of platforms in the PR description? |
76cc5e3
to
4fe59fe
Compare
@Fedosin thanks for the review. Once Azure PR is merged (where we are deciding which annotations/labels we want to use), we can distribute the same change to other actuators. |
Updating machine and machineset types in openshift/cluster-api first: openshift/cluster-api#55 |
Given we already support AWS, Azure and GCP instalations of OpenShift, reading values from machine provider config is no longer an option. Instead, let's read all needed values from machine annotations and labels. Each actuator will be then responsible for making sure every machine has all the annotations and labels that are needed to properly display additional machine columns set.
4fe59fe
to
4542417
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel Just validated OpenShift in both AWS and Azure properly display all relevant columns when running |
name: Node | ||
priority: 1 | ||
type: string | ||
- JSONPath: .spec.providerID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be from the status??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProviderID is spec field and there was a long discussion which of spec or status is the right place to put it. Spec won.
@ingvagabund hi! add the OpenStack PR please openshift/cluster-api-provider-openstack#55 |
@Fedosin there is no need to update machine CRD anymore. The CRD expects certain annotations and labels to be present in machine CR. If they are not, corresponding column is just empty. So, the only step needed to is update an actuator to set the requires annotations/labels. |
@ingvagabund correct. that's what I did in openshift/cluster-api-provider-openstack#55 |
Given we already support AWS, Azure and GCP instalations of OpenShift,
reading values from machine provider config is no longer an option.
Instead, let's read all needed values from machine annotations and labels.
Each actuator will be then responsible for making sure every machine
has all the annotations and labels that are needed to properly display
additional machine columns set.